fix: Force PLATFORMS environment variable when we build Elastic Agent dependencies on arm64 #26415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
1 task
kuisathaverat
requested review from
urso,
a team,
blakerouse,
michalpristas and
kaiyan-sheng
|
Greeeeeeen!!!!!
|
kuisathaverat
changed the title
mdelapenya
approved these changes
Jun 23, 2021
v1v
reviewed
Jun 23, 2021
cachedout
approved these changes
Jun 23, 2021
botelastic
bot
removed
the
needs_team
urso
reviewed
Jun 24, 2021
|
/test |
|
Pinging @elastic/agent (Team:Agent) |
urso
approved these changes
Jun 29, 2021
kuisathaverat
added
backport-v7.13.0
mdelapenya
added a commit
to mdelapenya/beats
that referenced
this pull request
Jun 30, 2021
* master: (25 commits) fix: Force PLATFORMS environment variable when we build Elastic Agent dependencies on arm64 (elastic#26415) macos for metricbeat to run in the extended meta-stage (elastic#26573) Packaging: add arm7 platform in the main pipeline (elastic#26575) [Heartbeat] Skip flakey timer queue test (elastic#26592) Update to "read_pipeline" permission (elastic#26465) (elastic#26580) API keys do not reflect the need for read_pipeline (elastic#26466) (elastic#26582) Add Fleet agent.id to Agent monitoring data (elastic#26548) Add kinesis metricset (elastic#25989) Refactor of system/memory metricset (elastic#26334) Introduce httpcommon package in libbeat (add support for Proxy) (elastic#25219) [Filebeat] change multiline configuration in awss3 input to parsers (elastic#25873) docs: Hint for the error "Error extracting container id" (elastic#25824) [Docs] Fixed metricbeat redis exported field CPU descriptions (elastic#25846) (elastic#26496) Update urllib to 1.26.5. (elastic#26380) Update golang.org/x/crypto (elastic#26448) [Filebeat] Update Fortinet Ingest Pipeline (elastic#24816) Move parsers outside of filestream input so others can use them as well (elastic#26541) [Filebeat] Fix `threatintel.indicator.url.full` field not populating (elastic#26508) [Filebeat] Add network direction processor to Zeek and Suricata modules (elastic#24620) Logging code cleanup related to Nomad auto-discovery (elastic#26498) ...
kuisathaverat
added a commit
that referenced
this pull request
Jun 30, 2021
… dependencies on arm64 (#26415) (#26602) * fix: build elastic agent dependencies on the architecture you are running * fix: format * fix: build ARM on ARM * fix: format * chore: backup the platforms env var (cherry picked from commit 5488dcf) Co-authored-by: Ivan Fernandez Calvo <kuisathaverat@users.noreply.github.com>
kuisathaverat
added a commit
that referenced
this pull request
Jun 30, 2021
… dependencies on arm64 (#26415) (#26603) * fix: build elastic agent dependencies on the architecture you are running * fix: format * fix: build ARM on ARM * fix: format * chore: backup the platforms env var (cherry picked from commit 5488dcf) Co-authored-by: Ivan Fernandez Calvo <kuisathaverat@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It forces the
PALFORMSenv var when we build the Elastic Agent beats dependencies in an arm64 host.Why is it important?
The current code tries to build amd64 packages in ARM architecture, we only support cross-compile for all architectures on amd64 machines. This causes that the mage package fails when you make it on an ARM host. The change in this PR build only amd64 binary dependencies in arm64.
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Launch a ubuntu-18.04/amd64 VM
Enter on x-pack/elastic-agent
Run mage package
It will build filebeat, metricbeat, heartbeat, and elastic-agent
Launch a ubuntu-18.04/arm64 VM
Enter on x-pack/elastic-agent
Run mage package
It will build Elastic-Agent only
Related issues
Use cases
Screenshots
Logs