Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MustAddMetricSet in all metricsets #26907

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Jul 15, 2021

What does this PR do?

Use MustAddMetricSet in all metricsets.

Why is it important?

To be consistent in how metricsets are registered.

As a follow up, we can remove AddMetricSet, but this is still useful as is used in tests and some other internal code.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@jsoriano jsoriano added module Metricbeat Metricbeat Team:Integrations Label for the Integrations team technical debt backport-v7.15.0 Automated backport with mergify labels Jul 15, 2021
@jsoriano jsoriano self-assigned this Jul 15, 2021
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 15, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 15, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 15, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-07-15T13:31:19.283+0000

  • Duration: 69 min 30 sec

  • Commit: 3c4c132

Test stats 🧪

Test Results
Failed 0
Passed 7398
Skipped 2135
Total 9533

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 7398
Skipped 2135
Total 9533

@jsoriano
Copy link
Member Author

/test

@jsoriano jsoriano merged commit c03d2ab into elastic:master Jul 19, 2021
@jsoriano jsoriano deleted the must-add-metric-set branch July 19, 2021 15:28
mergify bot pushed a commit that referenced this pull request Jul 19, 2021
jsoriano added a commit that referenced this pull request Jul 20, 2021
(cherry picked from commit c03d2ab)

Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
mdelapenya added a commit to mdelapenya/beats that referenced this pull request Jul 20, 2021
* master:
  Forward port 7.13.4 to master (elastic#26971)
  Use MustAddMetricSet in all metricsets (elastic#26907)
  add_process_metadata: enrich process info with process owner (elastic#21068) (elastic#21111)
  Use aws sdk paginator for FilterLogEvents and GetMetricData (elastic#26852)
  [Filebeat] Allow - for source IP for AWS S3 Access pipeline (elastic#26940)
  Increase timeout to 30secs (elastic#26841)
  Add Cluster filter on Kubernetes Overview ECS dashboard (elastic#26919)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.15.0 Automated backport with mergify Metricbeat Metricbeat module Team:Integrations Label for the Integrations team technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants