Disable monitoring during fleetserver bootstrap process #27222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the monitoring.enabled flag to false during the fleet-server bootstrap process in order to ensure that no data is sent to an elasticsearch instance running on the same host.
botelastic
bot
added
the
needs_team
botelastic
bot
removed
the
needs_team
michel-laterman
commented
Aug 3, 2021
| cfg.Settings.MonitoringConfig.Enabled = false | ||
| } else { | ||
| cfg.Settings.MonitoringConfig = &monitoringCfg.MonitoringConfig{Enabled: false} | ||
| } | ||
| monitor, err := monitoring.NewMonitor(cfg.Settings) |
There was a problem hiding this comment.
I attempted to replace the monitor with the noop monitor, but the agent was not able to bootstap correctly.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
|
Pinging @elastic/agent (Team:Agent) |
michel-laterman
added a commit
to michel-laterman/beats
that referenced
this pull request
Aug 17, 2021
* Disable monitoring during fleetserver bootstrap process Set the monitoring.enabled flag to false during the fleet-server bootstrap process in order to ensure that no data is sent to an elasticsearch instance running on the same host. * Add CHANGELOG entry
|
Hi @EricDavisX Observations:
Build details: Screenshot: Please let us know if anything else is required from our end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Set the monitoring.enabled flag to false during the fleet-server
bootstrap process in order to ensure that no data is sent to an
elasticsearch instance running on the same host.
Why is it important?
In a self-hosted scenario fleet will show that some data-streams have stopped in certain cases (such as after the fleet-server restarts). However these datastreams are incorrectly sent by the agent during the bootstrapping processes when the default credentials for output match Elasticsearch's credentials.
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Run ES + fleet locally (
elastic-packagecan do this), view the datastreams tab in the fleet-ui, theelastic_agent.metricsbeatandelastic_agent.filebeatstreams should not generate.Related issues