Inject inferred queue settings into agent config generation #27429
Conversation
faec
added
enhancement
Team:Elastic-Agent
|
Pinging @elastic/agent (Team:Agent) |
botelastic
bot
added
needs_team
|
This pull request doesn't have a |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
| name: "hello", | ||
| value: &StrVal{value: "fae was here"}, | ||
| } | ||
| if err := Insert(ast, faeNode, "output"); err != nil { |
There was a problem hiding this comment.
Should this be here at all? Was this a debugging thing?
I think if no output is defined it should just return nil and do nothing.
There was a problem hiding this comment.
Haha yes, leftover from when I was still figuring out how to traverse ASTs, removed
| name: "min_events", | ||
| value: &IntVal{value: min_events}, | ||
| }, | ||
| // flush.timeout defaults to 1s, which is what we want for now, |
There was a problem hiding this comment.
should we always set the default by Elastic Agent? that way if libbeat changes that doesn't affect what Elastic Agent expects?
no hard requirement to change this behavior, its just a thought
There was a problem hiding this comment.
I debated that... this has been a stable parameter but yea, let's make it explicit. Done.
(cherry picked from commit 9e6c6e1)
(cherry picked from commit 9e6c6e1)
What does this PR do?
Add a new internal rule,
inject_queue, to agent's config transpilation process, which derives implicit memory queue parameters from the user-specified output settings and injects them into the generated configuration, and call the rule from the appropriate spec files. See #26638 for details on the reasoning behind this feature.I haven't changed the documentation or default config files, since this change doesn't add any new user-customizable settings, it just adapts the backend settings better to the context. There should be a followup PR that clarifies that queue behavior is affected by output settings
bulk_max_sizeandworker, although we're intentionally not committing to an exact conversion formula since we may want to refine it in the future.Resolves #26638.
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.