-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metricbeat] gcp: add gke metricset documentation #27613
Conversation
Pinging @elastic/integrations (Team:Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
@@ -0,0 +1,31 @@ | |||
`gke` metricset is designed for collecting metrics from Google Kubernetes | |||
Engine. GKE is the industry's first fully managed Kubernetes service that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GKE is the industry's... I'm being picky here but I'd rather talk about Beat's product than talk about Google's product. What is GKE and why is (or not) awesome should be explained (and sold) in GCP GKE's homepage. All in all, this is the "homepage" of Metricbeat GKE metricset for GCP module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. I added it because I found the explanation for the monitored service in other metricsets and I copy/pasted from the GKE official page. I'll replace it with a link to the service home page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small comment but it's good enough already
(cherry picked from commit 07174bd)
(cherry picked from commit 07174bd)
…ion (#27703) Co-authored-by: endorama <526307+endorama@users.noreply.github.com>
…tion (#27704) Co-authored-by: endorama <526307+endorama@users.noreply.github.com> Co-authored-by: Edoardo Tenani <edoardo.tenani@elastic.co>
What does this PR do?
Provide documentation for GKE metricset.
Why is it important?
Metricset documentation was not present in #26824.
Checklist
My code follows the style guidelines of this projectI have commented my code, particularly in hard-to-understand areasI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksI have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs