Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore context cancell in status reporting #27668

Merged

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas commented Aug 31, 2021

What does this PR do?

Followup to #27210
This PR reduces context cancelled from status reporting including cases when process itself reports failure due to context cancelled.

Result is that two messages described in a comment linked below will disappear.
These does not alter behaviour and occur just at the time of restarting. But it may look like there's something wrong with process, operator or agent itself as failures propagate up.

Why is it important?

Fixes: #27062 (comment)

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@michalpristas michalpristas added bug Team:Elastic-Agent Label for the Agent team backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify labels Aug 31, 2021
@michalpristas michalpristas self-assigned this Aug 31, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 31, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-31T14:59:53.315+0000

  • Duration: 138 min 22 sec

  • Commit: c0ab917

Test stats 🧪

Test Results
Failed 0
Passed 24797
Skipped 1635
Total 26432

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 24797
Skipped 1635
Total 26432

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@michalpristas michalpristas changed the title ignore context cancell in status reporting Ignore context cancell in status reporting Sep 2, 2021
@michalpristas michalpristas merged commit d601e3f into elastic:master Sep 2, 2021
mergify bot pushed a commit that referenced this pull request Sep 2, 2021
mergify bot pushed a commit that referenced this pull request Sep 2, 2021
michalpristas added a commit that referenced this pull request Sep 2, 2021
(cherry picked from commit d601e3f)

Co-authored-by: Michal Pristas <michal.pristas@gmail.com>
michalpristas added a commit that referenced this pull request Sep 2, 2021
(cherry picked from commit d601e3f)

Co-authored-by: Michal Pristas <michal.pristas@gmail.com>
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify bug Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Agents]: "rpc error: code = Canceled desc" error logs on setting logging level to debug.
3 participants