Fix output.elasticsearch.proxy_disable flag #27671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename the output.elasticsearch.proxy_disabled flag to proxy_disable as that is what the flag appears as under all other settings including fleet.
michel-laterman
added
bug
Team:Elastic-Agent
|
Pinging @elastic/agent (Team:Agent) |
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
|
/test |
|
/test |
|
Shouldn't we do it the other way around and rename what is used in fleet-server? |
|
@ruflin |
|
7.14.1 is shipped, so it will be included in 7.14.2 (if and when that ships) |
|
@michel-laterman SGTM |
mergify bot
pushed a commit
that referenced
this pull request
Sep 2, 2021
* Fix output.elasticsearch.proxy_disable flag Rename the output.elasticsearch.proxy_disabled flag to proxy_disable as that is what the flag appears as under all other settings including fleet. * Add pr number to CHANGELOG (cherry picked from commit 0c9e194)
mergify bot
pushed a commit
that referenced
this pull request
Sep 2, 2021
* Fix output.elasticsearch.proxy_disable flag Rename the output.elasticsearch.proxy_disabled flag to proxy_disable as that is what the flag appears as under all other settings including fleet. * Add pr number to CHANGELOG (cherry picked from commit 0c9e194)
mergify bot
pushed a commit
that referenced
this pull request
Sep 2, 2021
* Fix output.elasticsearch.proxy_disable flag Rename the output.elasticsearch.proxy_disabled flag to proxy_disable as that is what the flag appears as under all other settings including fleet. * Add pr number to CHANGELOG (cherry picked from commit 0c9e194)
michel-laterman
added a commit
that referenced
this pull request
Sep 3, 2021
…27710) * Fix output.elasticsearch.proxy_disable flag (#27671) * Fix output.elasticsearch.proxy_disable flag Rename the output.elasticsearch.proxy_disabled flag to proxy_disable as that is what the flag appears as under all other settings including fleet. * Add pr number to CHANGELOG (cherry picked from commit 0c9e194) * Fix CHANGELOG Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com> Co-authored-by: michel-laterman <michel.laterman@elastic.co>
michel-laterman
added a commit
that referenced
this pull request
Sep 3, 2021
…27711) * Fix output.elasticsearch.proxy_disable flag (#27671) * Fix output.elasticsearch.proxy_disable flag Rename the output.elasticsearch.proxy_disabled flag to proxy_disable as that is what the flag appears as under all other settings including fleet. * Add pr number to CHANGELOG (cherry picked from commit 0c9e194) * Fix CHANGELOG Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com> Co-authored-by: michel-laterman <michel.laterman@elastic.co>
michel-laterman
added a commit
that referenced
this pull request
Sep 3, 2021
…27709) * Fix output.elasticsearch.proxy_disable flag (#27671) * Fix output.elasticsearch.proxy_disable flag Rename the output.elasticsearch.proxy_disabled flag to proxy_disable as that is what the flag appears as under all other settings including fleet. * Add pr number to CHANGELOG (cherry picked from commit 0c9e194) * Fix CHANGELOG Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com> Co-authored-by: michel-laterman <michel.laterman@elastic.co>
Icedroid
pushed a commit
to Icedroid/beats
that referenced
this pull request
Nov 1, 2021
* Fix output.elasticsearch.proxy_disable flag Rename the output.elasticsearch.proxy_disabled flag to proxy_disable as that is what the flag appears as under all other settings including fleet. * Add pr number to CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Rename the output.elasticsearch.proxy_disabled flag to proxy_disable as
that is what the flag appears as under all other settings including
fleet.
Why is it important?
fleet-server expects the setting to be named proxy_disable
Checklist
I have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues