-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.17](backport #30694) Fix/change the initialization of management layer #30805
Conversation
@Mergifyio update |
✅ Branch has been successfully updated |
Fix for metricbeat k8s #30870 |
This pull request is now in conflicts. Could you fix it? 🙏
|
* Ensure that libbeat manager is instantiated after the hooks. This fix an issues on Filebeat that make the start sequence of filebeat non-deterministic. It was possible that not all the hooks were configured correctly before the managed was receiving a configuration from the Elastic Agent. This causes an inconsistency between the expected configuration state and the actual running states, this includes the following symptoms: - Having Filebeat runnings and not sending any data to Elasticsearch - Having Filebeat partially configured, when only some inputs were sending data. - Missing log from the Filebeat collector - Having only metricsbeats running and sending logs. This solves the issues by moving the `Start` and stop `Stop` of the managed into the beats initialization process, each beats need to be adjusted to support. This is indeed a breaking changes for beats author, but the bootstrap process of beats and libbeat cannot easily be extended to make the change into a unique place. (cherry picked from commit 4c14f03)
c7eecb8
to
105a641
Compare
/test |
This pull request has not been merged yet. Could you please review and merge it @ph? 🙏 |
@v1v Any reason why this PR is stuck on testing? |
/test |
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
/test |
run elasticsearch-ci/docs |
This is an automatic backport of pull request #30694 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com