[8.0](backport #30694) Fix/change the initialization of management layer #30806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Ensure that libbeat manager is instantiated after the hooks. This fix an issues on Filebeat that make the start sequence of filebeat non-deterministic. It was possible that not all the hooks were configured correctly before the managed was receiving a configuration from the Elastic Agent. This causes an inconsistency between the expected configuration state and the actual running states, this includes the following symptoms: - Having Filebeat runnings and not sending any data to Elasticsearch - Having Filebeat partially configured, when only some inputs were sending data. - Missing log from the Filebeat collector - Having only metricsbeats running and sending logs. This solves the issues by moving the `Start` and stop `Stop` of the managed into the beats initialization process, each beats need to be adjusted to support. This is indeed a breaking changes for beats author, but the bootstrap process of beats and libbeat cannot easily be extended to make the change into a unique place. (cherry picked from commit 4c14f03)
botelastic
bot
added
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
|
@Mergifyio update |
✅ Branch has been successfully updated |
|
Fix for metricbeat k8s #30870 |
|
This pull request is now in conflicts. Could you fix it? 🙏 |
|
This pull request has not been merged yet. Could you please review and merge it @ph? 🙏 |
|
@v1v Any reason why this PR is stuck on testing? I've restarted it a few times. |
|
/test |
|
run elasticsearch-ci/docs |
mtojek
added
the
Team:Elastic-Agent-Control-Plane
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
botelastic
bot
removed
the
needs_team
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…astic#30806) This fix an issues on Filebeat that make the start sequence of filebeat non-deterministic. It was possible that not all the hooks were configured correctly before the managed was receiving a configuration from the Elastic Agent. This causes an inconsistency between the expected configuration state and the actual running states, this includes the following symptoms: - Having Filebeat runnings and not sending any data to Elasticsearch - Having Filebeat partially configured, when only some inputs were sending data. - Missing log from the Filebeat collector - Having only metricsbeats running and sending logs. This solves the issues by moving the `Start` and stop `Stop` of the managed into the beats initialization process, each beats need to be adjusted to support. This is indeed a breaking changes for beats author, but the bootstrap process of beats and libbeat cannot easily be extended to make the change into a unique place. (cherry picked from commit 48da76f) Co-authored-by: Pier-Hugues Pellerin <phpellerin@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #30694 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com