Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x-pack/filebeat/module/cisco: remove invalid values from ECS fields #31628

Merged
merged 2 commits into from
May 16, 2022
Merged

x-pack/filebeat/module/cisco: remove invalid values from ECS fields #31628

merged 2 commits into from
May 16, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented May 16, 2022

What does this PR do?

This prevents "monitored" from being written into event.outcome which
does not allow this value according to ECS.

Why is it important?

This brings the generated documents into conformance with ECS.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6
x-pack/filebeat/module/cisco: remove invalid values from ECS fields
3a8de77 
This prevents "monitored" from being written into event.outcome which
does not allow this value according to ECS.
@efd6 efd6 self-assigned this May 16, 2022
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 16, 2022
efd6
efd6 commented May 16, 2022
View reviewed changes
CHANGELOG.next.asciidoc Outdated Show resolved Hide resolved
@efd6 efd6 marked this pull request as ready for review May 16, 2022 01:56
@efd6 efd6 requested a review from a team as a code owner May 16, 2022 01:56
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link
Collaborator

elasticmachine commented May 16, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-16T01:57:12.468+0000

  • Duration: 68 min 11 sec

Test stats 🧪

Test Results
Failed 0
Passed 2099
Skipped 160
Total 2259

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6 efd6 merged commit 5a4bfca into elastic:main May 16, 2022
@efd6 efd6 deleted the cisco_asa-ftd_ecs branch May 16, 2022 09:14
mergify bot pushed a commit that referenced this pull request May 16, 2022
@efd6 @mergify
x-pack/filebeat/module/cisco: remove invalid values from ECS fields (#…
aecf59b 
…31628)

This prevents "monitored" from being written into event.outcome which
does not allow this value according to ECS.

(cherry picked from commit 5a4bfca)
@mergify mergify bot mentioned this pull request May 16, 2022
Merged
efd6 added a commit that referenced this pull request May 16, 2022
@mergify @efd6
x-pack/filebeat/module/cisco: remove invalid values from ECS fields (#…
f580bce 
…31628) (#31634)

This prevents "monitored" from being written into event.outcome which
does not allow this value according to ECS.

(cherry picked from commit 5a4bfca)

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
agithomas added a commit to agithomas/beats that referenced this pull request May 18, 2022
@agithomas
x-pack/filebeat/module/cisco: remove invalid values from ECS fields (e…
4c62bba 
…lastic#31628)

This prevents "monitored" from being written into event.outcome which
does not allow this value according to ECS.
agithomas added a commit to agithomas/beats that referenced this pull request Nov 3, 2022
@agithomas
x-pack/filebeat/module/cisco: remove invalid values from ECS fields (e…
c3e5116 
…lastic#31628)

This prevents "monitored" from being written into event.outcome which
does not allow this value according to ECS.
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@efd6 @chrisberkhout
x-pack/filebeat/module/cisco: remove invalid values from ECS fields (#…
65bc6df 
…31628)

This prevents "monitored" from being written into event.outcome which
does not allow this value according to ECS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriansr adriansr adriansr approved these changes

Assignees

@efd6 efd6

Labels
8.3-candidate backport-v8.2.0 Automated backport with mergify bug Filebeat Filebeat Integration:Cisco
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@efd6 @elasticmachine @adriansr