Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transform beat.cgroup.memory.mem.usage.bytes to Gauge #32652

Merged

Conversation

boranx
Copy link
Contributor

@boranx boranx commented Aug 10, 2022

What does this PR do?

This transforms beat.cgroup.memory.mem.usage.bytes to Gauge as it can have a negative value

Why is it important?

it tries to eliminate Non-zero metrics in the last 30s errors by transforming beat.cgroup.memory.mem.usage.bytes to gauge

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Fix: #31582

Use cases

Screenshots

Logs

@boranx boranx requested a review from a team as a code owner August 10, 2022 16:02
@boranx boranx requested review from rdner and cmacknz and removed request for a team August 10, 2022 16:02
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 10, 2022
@cla-checker-service
Copy link

cla-checker-service bot commented Aug 10, 2022

💚 CLA has been signed

@mergify mergify bot assigned boranx Aug 10, 2022
@boranx boranx force-pushed the gauge-beat-cgroup-memory-mem-usage-bytes branch from 1ecf76a to a5d514e Compare August 10, 2022 16:04
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 10, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-10T18:36:55.652+0000

  • Duration: 87 min 37 sec

Test stats 🧪

Test Results
Failed 0
Passed 22559
Skipped 1937
Total 24496

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@cmacknz cmacknz added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Aug 10, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 10, 2022
@cmacknz
Copy link
Member

cmacknz commented Aug 10, 2022

Changes look good, you'll need to sign the CLA and then we can kick the tests and get this merged.

@boranx
Copy link
Contributor Author

boranx commented Aug 10, 2022

I'd bet I've signed this a couple of hours ago, but in order to reflect the changes, should we re-trigger ci?

/test

@cmacknz
Copy link
Member

cmacknz commented Aug 10, 2022

/test

@cmacknz
Copy link
Member

cmacknz commented Aug 10, 2022

Yes, CLA check has passed now. Someone from Elastic has to trigger the first test run, which I've now done.

We can ignore the linter errors here as they aren't caused by changes you've made (it always wants to lint the entire file, not just the changed lines).

@cmacknz cmacknz merged commit 722f981 into elastic:main Aug 11, 2022
@cmacknz
Copy link
Member

cmacknz commented Aug 11, 2022

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug libbeat Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[libbeat] beat.cgroup.memory.mem.usage.bytes should be a gauge in metrics
4 participants