Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libbeat/processors/cache: don't write cache states that have not been altered #36696

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Sep 28, 2023

Proposed commit message

Add a dirty flag to memStore to be used by fileStore so that needless writes
are not performed.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 self-assigned this Sep 28, 2023
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 28, 2023
@efd6 efd6 force-pushed the i2816-cache_processor_file_backed_dirtyness branch from 04f38e4 to 1fe4a81 Compare September 28, 2023 06:27
@efd6 efd6 marked this pull request as ready for review September 28, 2023 06:31
@efd6 efd6 requested a review from a team as a code owner September 28, 2023 06:31
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 28, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 18 min 27 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6 efd6 force-pushed the i2816-cache_processor_file_backed_dirtyness branch from 1fe4a81 to 43b8f48 Compare September 28, 2023 20:32
… altered

Add a dirty flag to memStore to be used by fileStore so that needless writes
are not performed.
@efd6 efd6 force-pushed the i2816-cache_processor_file_backed_dirtyness branch from 43b8f48 to 0cd0db2 Compare September 28, 2023 21:56
@efd6
Copy link
Contributor Author

efd6 commented Sep 28, 2023

/test

@efd6 efd6 enabled auto-merge (squash) September 29, 2023 08:03
@efd6 efd6 merged commit 4d74439 into elastic:main Sep 29, 2023
85 of 87 checks passed
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
… altered (elastic#36696)

Add a dirty flag to memStore to be used by fileStore so that needless writes
are not performed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.11-candidate backport-skip Skip notification from the automated backport with mergify enhancement libbeat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants