x-pack/filebeat/input/{websocket=>streaming}: rename package #40421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
enhancement
Filebeat
botelastic
bot
added
needs_team
efd6
force-pushed
the
40264-websocket_rename
branch
3 times, most recently
from
983417c
to
7c7c924
Compare
efd6
force-pushed
the
40264-websocket_rename
branch
from
7c7c924
to
b902459
Compare
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
pierrehilbert
added
the
Team:Elastic-Agent-Data-Plane
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
andrewkroh
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Does the inclusion point of this file need changed to keep the input list sorted alphabetically?
There was a problem hiding this comment.
andrewkroh
reviewed
Aug 6, 2024
| @@ -156,4 +156,4 @@ include::inputs/input-udp.asciidoc[] | |||
|
|
|||
| include::inputs/input-unix.asciidoc[] | |||
|
|
|||
| include::../../x-pack/filebeat/docs/inputs/input-websocket.asciidoc[] | |||
| include::../../x-pack/filebeat/docs/inputs/input-streaming.asciidoc[] | |||
There was a problem hiding this comment.
I think this line needs moved up to ~L150.
There was a problem hiding this comment.
I miss mechanically generated documentation rendering.
belimawr
approved these changes
Aug 7, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
See title.
This has been tested by injecting an
agentbeatcompiled with this version into a running 8.15 elastic-package stack and then running the proofpoint_on_demand integration, an integration that depends on the websocket input.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs