Reorganization and Addition: Move TLS types and config out of the outputs and support server options. #7054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ph
force-pushed
the
refactor/tls-out-of-output
branch
from
1ed6bb2
to
64fdbd1
Compare
ph
force-pushed
the
refactor/tls-out-of-output
branch
2 times, most recently
from
c0b62d2
to
5002054
Compare
This was referenced May 9, 2018
|
I've rekick some Travis job which hit an http timeout when installing apt package. |
ph
force-pushed
the
refactor/tls-out-of-output
branch
from
5002054
to
9aea7f4
Compare
|
@kvch I've updated the original PR with the new options: client_authentication.`, lets review this one first. |
|
jenkins test this please |
kvch
reviewed
May 16, 2018
|
|
||
| s, ok := in.(string) | ||
| if !ok { | ||
| return fmt.Errorf("client authentification must be an identifier") |
kvch
reviewed
May 16, 2018
|
|
||
| mode, found := tlsClientAuthTypes[s] | ||
| if !found { | ||
| return fmt.Errorf("unknown client authentification mode'%v'", s) |
…puts and support server options. When working on the TLS TCP it was a bit strange to import a package coming from the outputs; this commit addresses a few things: - Move the `outputs/tls.go` and `transport/tls.go` into the common under the transport folder. - Add shims to make sure we keep backward compatibility on anything that could be using theses classes. - Extract common logic code to be reusable. - Add inverse mapper for TLSVersion and tlsCiphersuite, to give a uint and get the human string. - Add a new `ServerConfig` config struct. *This is a light refactoring, mostly moving code and adding a few tests. Fixes: elastic#6079
I think my french influence slipped on that one.
ph
force-pushed
the
refactor/tls-out-of-output
branch
from
9aea7f4
to
0b1d1ad
Compare
|
@kvch Updated with the requested changes, I also added |
stevea78
pushed a commit
to stevea78/beats
that referenced
this pull request
May 20, 2018
…puts and support server options. (elastic#7054) * Reorganization and Addition: Move TLS types and config out of the outputs and support server options. When working on the TLS TCP it was a bit strange to import a package coming from the outputs; this commit addresses a few things: - Move the `outputs/tls.go` and `transport/tls.go` into the common under the transport folder. - Add shims to make sure we keep backward compatibility on anything that could be using theses classes. - Extract common logic code to be reusable. - Add inverse mapper for TLSVersion and tlsCiphersuite, to give a uint and get the human string. - Add a new `ServerConfig` config struct. *This is a light refactoring, mostly moving code and adding a few tests. Fixes: elastic#6079 * Adding: Developer changelog * rename client_authentification to client_authentication I think my french influence slipped on that one. * authenfitication -> authentication
stevea78
pushed a commit
to stevea78/beats
that referenced
this pull request
May 20, 2018
…puts and support server options. (elastic#7054) * Reorganization and Addition: Move TLS types and config out of the outputs and support server options. When working on the TLS TCP it was a bit strange to import a package coming from the outputs; this commit addresses a few things: - Move the `outputs/tls.go` and `transport/tls.go` into the common under the transport folder. - Add shims to make sure we keep backward compatibility on anything that could be using theses classes. - Extract common logic code to be reusable. - Add inverse mapper for TLSVersion and tlsCiphersuite, to give a uint and get the human string. - Add a new `ServerConfig` config struct. *This is a light refactoring, mostly moving code and adding a few tests. Fixes: elastic#6079 * Adding: Developer changelog * rename client_authentification to client_authentication I think my french influence slipped on that one. * authenfitication -> authentication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on the TLS TCP it was a bit strange to import a
package coming from the outputs; this commit addresses a few things:
outputs/tls.goandtransport/tls.gointo the commonunder the transport folder.
could be using theses classes.
and get the human string.
ServerConfigconfig struct.*This is a light refactoring, mostly moving code and adding a few
tests.