Emphasize the importance of having snapshot #8051
Open
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have seen many master pods got lost thus having to repair the whole cluster use cases, and we'd like to emphasize the importance about having snapshot to call out it explicitly clear.
thbkrkr
approved these changes
Sep 13, 2024
| @@ -8,6 +8,8 @@ endif::[] | |||
| [id="{p}-{page_id}"] | |||
| = Create automated snapshots | |||
|
|
|||
| NOTE: Snapshots are important to ensure that your Elasticsearch indices can be recovered in the event of an accidental deletion, or to migrate data across clusters. | |||
There was a problem hiding this comment.
It's up to you to decide, but here's another suggestion that's a little more direct and concise.
Suggested change
| NOTE: Snapshots are important to ensure that your Elasticsearch indices can be recovered in the event of an accidental deletion, or to migrate data across clusters. | |
| NOTE: Snapshots are essential for recovering Elasticsearch indices in case of accidental deletion or for migrating data between clusters. |
barkbay
reviewed
Sep 13, 2024
| @@ -8,6 +8,8 @@ endif::[] | |||
| [id="{p}-{page_id}"] | |||
| = Create automated snapshots | |||
|
|
|||
| NOTE: Snapshots are important to ensure that your Elasticsearch indices can be recovered in the event of an accidental deletion, or to migrate data across clusters. | |||
There was a problem hiding this comment.
Should we have this note as a header of the "Run Elasticsearch on ECK" section here. I'm asking because my feeling is that if someone is looking at the snapshot documentation then it may mean that this person is already aware that it's an important topic (or maybe because it's too late 🙃 )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:: Reason for the PR
We have seen many master pods got lost thus having to repair the whole cluster use cases, and we'd like to emphasize the importance about having snapshot to call out it explicitly clear.
:: After merge:
Orange part will be added
Text is something similar from ESS - https://www.elastic.co/guide/en/cloud/current/ec-snapshot-restore.html
But we don't say "deployment" in ECK so I used clusters.