fix(deploy): move '$leading_path' variable definition in eck-operator

[devzizu]

Description

This PR fixes an error that is thrown by Helm when templating the eck-operator chart. In this case, consider the following variables file:

config:
  metrics:
    port: "6000"
    secureMode:
      enabled: true
      tls:
        certificateSecret: "my-metrics-cert-secret"
        caSecret: "my-metrics-cert-secret"
        insecureSkipVerify: false

Running helm template with the above values generates the following error:

Error: template: eck-operator/templates/serviceMonitor.yaml:25:49: executing "eck-operator/templates/serviceMonitor.yaml" at <.Values.config.metrics.secureMode.tls.caMountDirectory>: can't evaluate field Values in type string

Use --debug flag to render out invalid YAML

This error occurs because when modifying the scope using with, the reference for .Values, for example, is lost (helm docs).

Also, unit tests pass with make helm-test (using Helm v3.14 and unittest v0.2.8).

PR requirements

• Have you signed the contributor license agreement?
• Have you followed the contributor guidelines?
• If you submit code, is your pull request against main? We recommend pull requests against main. We will backport them as needed.

[thbkrkr]

buildkite test this

[thbkrkr]

Thank you!

[devzizu]

@thbkrkr Thanks for the review! Can we backport this to prior versions of the chart as well?

[thbkrkr]

buildkite test this

[thbkrkr]

@thbkrkr Thanks for the review! Can we backport this to prior versions of the chart as well?

Thank you for the suggestion! We generally release prior versions only for critical bug fixes, so we might not backport this change to earlier versions unless it is deemed necessary.