Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CONTRIBUTING.md #10

Merged
merged 2 commits into from
Feb 17, 2021

Conversation

charith-elastic
Copy link
Contributor

No description provided.

@charith-elastic charith-elastic added the documentation Improvements or additions to documentation label Feb 16, 2021
Copy link
Contributor

@barkbay barkbay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, should it be also mentioned in a PR template ?

CONTRIBUTING.md Outdated
@@ -0,0 +1,8 @@
= Contributing to crd-ref-docs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: markdownlint is complaining with the following messages:

MD041/first-line-heading/first-line-h1: First line in file should be a top level heading

IIRC = is an alternative that should be used below the text.

@charith-elastic charith-elastic merged commit 3a36eb9 into elastic:master Feb 17, 2021
@charith-elastic charith-elastic deleted the docs/contributing branch February 17, 2021 08:24
charith-elastic added a commit to charith-elastic/crd-ref-docs that referenced this pull request Feb 19, 2021
* Add CONTRIBUTING.md

* Fix header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants