Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Markdown #16

Merged
merged 2 commits into from
Nov 22, 2021
Merged

Add support for Markdown #16

merged 2 commits into from
Nov 22, 2021

Conversation

unguiculus
Copy link
Contributor

  • Add renderer for Markdown
  • Add templates for Markdown
  • Add Markdown tests to test.sh

@unguiculus
Add support for Markdown
4075980 
* Add renderer for Markdown
* Add templates for Markdown
* Add Markdown tests to test.sh
thbkrkr
thbkrkr reviewed Nov 3, 2021
View reviewed changes
Copy link
Contributor

@thbkrkr thbkrkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thank you. Almost LGTM. I left a few minor comments.

README.md Outdated Show resolved Hide resolved
test.sh Show resolved Hide resolved
renderer/markdown.go Show resolved Hide resolved
@unguiculus @thbkrkr
Update README.md
a25dd18 
Co-authored-by: Thibault Richard <thbkrkr@users.noreply.github.com>
@thbkrkr thbkrkr merged commit b15937a into elastic:master Nov 22, 2021
@unguiculus unguiculus deleted the feature/markdown branch November 24, 2021 14:25
@thbkrkr thbkrkr added the enhancement New feature or request label Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thbkrkr thbkrkr thbkrkr approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@unguiculus @thbkrkr