Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fix formatting in test types #32

Merged
merged 1 commit into from
Jul 28, 2022
Merged

refactor: fix formatting in test types #32

merged 1 commit into from
Jul 28, 2022

Conversation

mikaello
Copy link
Contributor

The changes in #25 does not follow gofmt, this PR fixes that.

@cla-checker-service
Copy link

cla-checker-service bot commented Jul 15, 2022

💚 CLA has been signed

Copy link
Contributor

@thbkrkr thbkrkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty!

Could you please sign the CLA and we can merge it in?

@mikaello
Copy link
Contributor Author

Could you please sign the CLA and we can merge it in?

I have signed it multiple times already, I thought maybe you had to accept it as well? I signed it a third (or fourth) time now, just to be sure 😅

@thbkrkr
Copy link
Contributor

thbkrkr commented Jul 26, 2022

@mikaello You must sign with the same email you use to commit. You committed with @statnett.no and signed with @gmail.com.

@mikaello
Copy link
Contributor Author

@mikaello You must sign with the same email you use to commit.

Seems like this is not the case, I have now fixed the commit so it uses an email that I have connected to my account, but not the email I signed with, and that worked (CLA is now signed according to cla-checker-servire).

@thbkrkr thbkrkr merged commit 3a11386 into elastic:master Jul 28, 2022
@mikaello mikaello deleted the fix-formatting branch July 28, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants