Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort kinds #4

Merged
merged 3 commits into from
May 15, 2020
Merged

Sort kinds #4

merged 3 commits into from
May 15, 2020

Conversation

charith-elastic
Copy link
Contributor

If there is more than one kind in a package, the order in which they are rendered can change between runs. This PR adds a helper to retrieve a sorted list of kinds during rendering.

Also adds a script to check the output produced by the tool.

@charith-elastic charith-elastic added the enhancement New feature or request label May 14, 2020
Copy link

@sebgl sebgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Super happy to see the output test!
I left a few minor comments, nothing preventing a merge.

else
echo "OK"
fi
)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 I'm very happy to see this.

types/types.go Outdated Show resolved Hide resolved
types/types.go Outdated Show resolved Hide resolved
@charith-elastic charith-elastic merged commit be60e15 into elastic:master May 15, 2020
@charith-elastic charith-elastic deleted the sorted-kinds branch May 15, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants