Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for generating separate files for each group #67

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Support for generating separate files for each group #67

merged 1 commit into from
Mar 7, 2024

Conversation

airycanon
Copy link
Contributor

Resolve #59

@cla-checker-service CLA Checker Service
Copy link

cla-checker-service bot commented Mar 1, 2024 •
edited
Loading

💚 CLA has been signed

@airycanon
Copy link
Contributor Author

@thbkrkr @tenstad Could you please take a look at this pull request?

thbkrkr
thbkrkr reviewed Mar 6, 2024
View reviewed changes
Copy link
Contributor

@thbkrkr thbkrkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good overall, but I would write it slightly differently.

renderer/renderer.go Outdated Show resolved Hide resolved
renderer/renderer.go Show resolved Hide resolved
renderer/renderer.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
@airycanon
Copy link
Contributor Author

It looks good overall, but I would write it slightly differently.

Thank you for the review and the suggestions! I've made the recommended improvements. Could you please take another look?

@thbkrkr thbkrkr added the enhancement New feature or request label Mar 7, 2024
@thbkrkr thbkrkr changed the title add output mode option Support for generating separate files for each group Mar 7, 2024
@thbkrkr thbkrkr merged commit 83e2ff3 into elastic:master Mar 7, 2024
2 checks passed
@thbkrkr
Copy link
Contributor

thbkrkr commented Mar 7, 2024

Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thbkrkr thbkrkr thbkrkr left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Support for outputting multiple files
2 participants
@airycanon @thbkrkr