Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rule Tuning] 7.11.2: Add timestamp_override to all query and non-sequence EQL rules #948

Merged

Conversation

brokensound77
Copy link
Contributor

Issues

related to https://github.com/elastic/security-team/issues/746
related to #945

Summary

For rules in 7.11.2, set timestamp_override = "event.ingested" for all KQL, Lucene, and non-sequence EQL rules to account for misses that would result from ingest delays exceeding the lookback time defined in the rule.

#945 will update any new rules introduced since 7.12 release package

@brokensound77 brokensound77 added Rule: Tuning tweaking or tuning an existing rule v7.11.2 labels Feb 16, 2021
Copy link
Contributor

@rw-access rw-access left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I don't know if we want to change the lock here or after a release of 7.11.2.
I'm indifferent, but figure that additional changes are unlikely and you want to save a PR

@brokensound77
Copy link
Contributor Author

LGTM.
I don't know if we want to change the lock here or after a release of 7.11.2.
I'm indifferent, but figure that additional changes are unlikely and you want to save a PR

Right, that was my thinking - shouldn't have more changes for 7.11.2

@brokensound77 brokensound77 merged commit 61deed3 into elastic:7.11 Feb 16, 2021
@brokensound77 brokensound77 deleted the rule-tuning/timestamp-override-7.11.2 branch February 16, 2021 19:52
brokensound77 added a commit that referenced this pull request Feb 17, 2021
* lock versions for rule changes in v7.11.0 (#947)
* [Rule Tuning] 7.11.2: Add timestamp_override to all query and non-sequence EQL rules (#948)
* [Rule Tuning] Add timestamp_override field to 7.11.0 rules
* Lock versions for 7.11.2 rules
* [Rule Tuning] Remove timestamp_override for endgame-* promotion rules (#951)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rule: Tuning tweaking or tuning an existing rule v7.11.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants