Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate X-Pack Reference and Stack Overview #1490

Merged
merged 1 commit into from
Dec 2, 2019

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Nov 29, 2019

The :xpack-ref: shared attribute is defined in https://github.com/elastic/docs/blob/master/shared/attributes.asciidoc such that it equates to the Stack Overview. This helped avoid broken links when the Stack Overview was first created.

However, there are places in the Cloud documentation where we need to be able to refer to old books as well as new ones. This PR sets the :xpack-ref: attribute to the final 6.2 version for the X-Pack Reference book so those old references can still work.

Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl
Copy link
Contributor Author

lcawl commented Nov 30, 2019

@elasticmachine run elasticsearch-ci/docs

@lcawl
Copy link
Contributor Author

lcawl commented Nov 30, 2019

@elacticmachine run elasticsearch-ci/docs

@lcawl
Copy link
Contributor Author

lcawl commented Dec 2, 2019

@elasticmachine run elasticsearch-ci/docs

1 similar comment
@lcawl
Copy link
Contributor Author

lcawl commented Dec 2, 2019

@elasticmachine run elasticsearch-ci/docs

@lcawl lcawl merged commit d9c04f9 into elastic:master Dec 2, 2019
@lcawl lcawl deleted the xpack-ref branch December 2, 2019 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants