Add kibana dependency to Glossary #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtback
reviewed
Jun 25, 2020
conf.yaml
Outdated
| @@ -131,6 +131,9 @@ contents: | |||
| - | |||
| repo: elasticsearch | |||
| path: docs/reference | |||
| - | |||
| repo: kibana | |||
| path: docs | |||
There was a problem hiding this comment.
This is OK as is, but if we don't want to rebuild the glossary anytime any of the Kibana docs change, we can use this instead:
Suggested change
| path: docs | |
| path: docs/glossary.asciidoc |
Do I understand that correctly, @nik9000 ?
There was a problem hiding this comment.
Ah, if that's the case I'll make the same change to the Glossary's elasticsearch dependency. It only cares about one file there too.
gtback
approved these changes
Jun 26, 2020
|
@elasticmachine run elasticsearch-ci/docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to elastic/kibana#69721
This PR adds the kibana repo as a resource for the Glossary so that it can pull tagged sections from that repo.