Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Journalbeat to legacy section and turn off 7.16+ builds #2296

Merged
merged 3 commits into from
Nov 24, 2021
Merged

Move Journalbeat to legacy section and turn off 7.16+ builds #2296

merged 3 commits into from
Nov 24, 2021

Conversation

dedemorton
Copy link
Contributor

@dedemorton dedemorton commented Nov 24, 2021 •
edited
Loading

@dedemorton dedemorton requested a review from kvch November 24, 2021 22:26
kilfoyle
kilfoyle approved these changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a drive-by LGTM! 🚀

@dedemorton dedemorton merged commit faae90a into elastic:master Nov 24, 2021
@dedemorton dedemorton deleted the remove_journalbeat branch November 24, 2021 23:24
@dedemorton dedemorton self-assigned this Nov 24, 2021
gtback
gtback reviewed Nov 29, 2021
View reviewed changes
Copy link
Member

@gtback gtback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After-the-fact LGTM.

Taking out the references to variables that will get updated (like stacklive and stackcurrent) is the most important part, which you did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtback gtback gtback left review comments

@kilfoyle kilfoyle kilfoyle approved these changes

@kvch kvch Awaiting requested review from kvch

Assignees

@dedemorton dedemorton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dedemorton @gtback @kilfoyle