Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for service.version and service.environment with apmInstrumentation #121

Closed
trentm opened this issue May 10, 2022 · 1 comment · Fixed by #152
Closed

add support for service.version and service.environment with apmInstrumentation #121

trentm opened this issue May 10, 2022 · 1 comment · Fixed by #152
Assignees
@trentm
Labels
agent-nodejs Make available for APM Agents project planning.

Comments

@trentm
Copy link
Member

trentm commented May 10, 2022

service.version, at least, has been added to the ecs-logging spec:
https://github.com/elastic/ecs-logging/blob/d8ee4d4ba5853a10425ac21f41a5ff04f84b355b/spec/spec.json#L88-L96
with the comment that:

When an APM agent is active, it should auto-configure it if not already set.

The spec will be sync'd here with #120.

Then ecs-logging-java added support for service.version and service.environment:

Should the node.js ecs-logging libs do the same?
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label May 10, 2022
@trentm
Copy link
Member Author

trentm commented May 16, 2022

This adds service.environment to the spec as well now: #123

@trentm trentm self-assigned this Oct 14, 2023
trentm added a commit that referenced this issue Oct 16, 2023
@trentm
feat: more correlation fields: service.version, service.environment, …
bb811ed 
…service.node.name

These are retrieved from an active APM agent, if apmIntegration is
enabled. As well, config options for overriding these (and service.name)
have been added.

Closes: #121
Closes: #87
Refs: elastic/apm-agent-nodejs#3195
@trentm trentm mentioned this issue Oct 16, 2023
Merged
trentm added a commit to elastic/apm-agent-nodejs that referenced this issue Oct 16, 2023
@trentm
feat: apm.getServiceVersion(), apm.getServiceEnvironment(), apm.getSe…
3b78c88 
…rviceNodeName()

For use by ecs-logging-nodejs packages for log correlation.

Refs: elastic/ecs-logging-nodejs#121
Refs: 3195
@trentm trentm mentioned this issue Oct 16, 2023
Merged
trentm added a commit to elastic/apm-agent-nodejs that referenced this issue Oct 17, 2023
@trentm
feat: apm.getServiceVersion(), apm.getServiceEnvironment(), apm.getSe…
d968537 
…rviceNodeName() (#3679)

For use by ecs-logging-nodejs packages for log correlation.

Refs: elastic/ecs-logging-nodejs#121
Refs: #3195
trentm added a commit that referenced this issue Oct 17, 2023
@trentm
feat: more correlation fields: service.version, service.environment, …
2a17af3 
…service.node.name (#152)

These are retrieved from an active APM agent, if `apmIntegration` is
enabled. As well, config options for overriding these (and service.name)
have been added.

Closes: #121
Closes: #87
Refs: elastic/apm-agent-nodejs#3195
@trentm trentm mentioned this issue Oct 17, 2023
Merged
fpm-peter pushed a commit to fpm-git/apm-agent-nodejs that referenced this issue Aug 20, 2024
@trentm @fpm-peter
feat: apm.getServiceVersion(), apm.getServiceEnvironment(), apm.getSe…
8632fc9 
…rviceNodeName() (elastic#3679)

For use by ecs-logging-nodejs packages for log correlation.

Refs: elastic/ecs-logging-nodejs#121
Refs: elastic#3195
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trentm trentm

Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Milestone
No milestone
1 participant
@trentm