Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"@elastic/ecs-pino-format" has a deprecated transitive dependency "string-similarity" #144

Closed
staskorz opened this issue May 5, 2023 · 2 comments · Fixed by #155
Closed

"@elastic/ecs-pino-format" has a deprecated transitive dependency "string-similarity" #144

staskorz opened this issue May 5, 2023 · 2 comments · Fixed by #155
Labels
agent-nodejs Make available for APM Agents project planning. community

Comments

@staskorz
Copy link

staskorz commented May 5, 2023

"@elastic/ecs-pino-format" depends on "@elastic/ecs-helpers", which depends on an old version of "fast-json-stringify", which depends on "string-similarity" which is deprecated:

@elastic/ecs-pino-format > @elastic/ecs-helpers > fast-json-stringify > string-similarity@4.0.4: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.

Newer versions of "fast-json-stringify" do not depend on "string-similarity" any more.
@github-actions github-actions bot added agent-nodejs Make available for APM Agents project planning. community triage labels May 5, 2023
@trentm
Copy link
Member

trentm commented Oct 3, 2023

See discussion at #145
This'll require a major ver bump to raise the min supported Node.js to v14.17.0.
I hope to do so relatively soon.

@trentm trentm removed the triage label Oct 3, 2023
@trentm trentm mentioned this issue Oct 18, 2023
Merged
2 tasks
trentm added a commit that referenced this issue Oct 24, 2023
@trentm
feat: switch to safe-stable-stringify for safer serialization (#155)
efb11b7 
This drops the schema-based fast-json-stringify usage, which could
potentially be faster, but will throw on circular references. The
safer serialization is more appropriate for logging libs. Note that
currently both pino and winston themselves use safe-stable-stringify.

Add explicit dep for triple-beam, rather than getting lucky.
Use a Format class to avoid needing a dep on winston or logform
for the 'winston.format(...)' call.

Document subtle diffs with our stringifier and winston.format.json().

Closes: #104
Closes: #144
Closes: #145
Closes: #108
@trentm
Copy link
Member

trentm commented Oct 24, 2023

This'll require a major ver bump to raise the min supported Node.js to v14.17.0.

Update from #155: this will not require a major version bump. Releases v1.5.0 and later will have this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
agent-nodejs Make available for APM Agents project planning. community
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: switch to safe-stable-stringify for safer serialization elastic/ecs-logging-nodejs
2 participants
@trentm @staskorz