Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for tracing fields #35

Closed
trentm opened this issue Jan 19, 2021 · 2 comments
Closed

add support for tracing fields #35

trentm opened this issue Jan 19, 2021 · 2 comments
Assignees
@trentm
Labels
agent-nodejs Make available for APM Agents project planning.

Comments

@trentm
Copy link
Member

trentm commented Jan 19, 2021

The ECS log formatters should detect usage of Elastic APM (the elastic-apm-node package) and add tracing fields (https://www.elastic.co/guide/en/ecs/current/ecs-tracing.html) to log records if there is an active trace.
@trentm trentm added the agent-nodejs Make available for APM Agents project planning. label Jan 19, 2021
@trentm trentm self-assigned this Jan 19, 2021
trentm added a commit that referenced this issue Jan 19, 2021
@trentm
feat(pino): add ECS tracing fields if APM is in use
7947465 
Refs: #35
@trentm trentm mentioned this issue Jan 19, 2021
Merged
trentm added a commit that referenced this issue Jan 19, 2021
@trentm
feat(pino): add ECS tracing fields if APM is in use (#36)
e4c090c 
Refs: #35
@trentm
Copy link
Member Author

trentm commented Jan 20, 2021

Note that elastic/ecs-logging#27 calls just for trace.id and transaction.id. The JS ecs-logging libs will also add "span.id" from the ECS Tracing fields because there is no perf hit in doing so.
However, "currently, span.id is not used in the [Kibana] UI for correlation." -- Felix

trentm added a commit that referenced this issue Jan 20, 2021
@trentm
feat(winston): add ECS tracing fields if APM is in use
4276b03 
Refs: #35
@trentm trentm mentioned this issue Jan 20, 2021
Merged
trentm added a commit that referenced this issue Jan 20, 2021
@trentm
feat(winston): add ECS tracing fields if APM is in use (#39)
09edd01 
Refs: #35
trentm added a commit that referenced this issue Jan 20, 2021
@trentm
feat(morgan): add ECS tracing fields if APM is in use (#39)
2c68acb 
Refs: #35
@trentm trentm mentioned this issue Jan 20, 2021
Merged
trentm added a commit that referenced this issue Jan 20, 2021
@trentm
feat(morgan): add ECS tracing fields if APM is in use (#40)
4186405 
Refs: #35
@trentm
Copy link
Member Author

trentm commented Jan 21, 2021

Published in helpers module v0.4.0 (https://github.com/elastic/ecs-logging-js/blob/master/helpers/CHANGELOG.md#v040). Done for pino, winston, morgan. This'll be in the next releases of those.

@trentm trentm closed this as completed Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trentm trentm

Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@trentm