Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(winston): add TS types #88

Merged
merged 1 commit into from
Aug 23, 2021
Merged

feat(winston): add TS types #88

merged 1 commit into from
Aug 23, 2021

Conversation

dliv
Copy link
Contributor

@dliv dliv commented Aug 23, 2021

This is essentially the same as the Pino PR #82 .

For: #77 .

This is essentially the same as the Pino PR #82 .
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Aug 23, 2021
@apmmachine
Copy link
Contributor

apmmachine commented Aug 23, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-23T21:07:20.927+0000

  • Duration: 7 min 23 sec

  • Commit: c14fb46

Trends 🧪

Image of Build Times

@trentm
Copy link
Member

trentm commented Aug 23, 2021

@dliv This is great, thanks! I'll try to take a look at this soon.

(note to self: I assume this doesn't collide with #65 -- my fault for taking so long to get that merged)

@trentm trentm added this to the 7.16 milestone Aug 23, 2021
@trentm
Copy link
Member

trentm commented Aug 23, 2021

jenkins run the tests

@dliv
Copy link
Contributor Author

dliv commented Aug 23, 2021

@dliv This is great, thanks! I'll try to take a look at this soon.

(note to self: I assume this doesn't collide with #65 -- my fault for taking so long to get that merged)

Glanced at 65 and I think they're compat: top level export preserved, options unchanged (?). Would be nice to add in the named exports after 65.

Copy link
Member

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trentm trentm merged commit f8552a5 into elastic:master Aug 23, 2021
@dliv dliv deleted the GH-77/winston-types branch August 23, 2021 21:46
@trentm
Copy link
Member

trentm commented Aug 23, 2021

@elastic/ecs-winston-format@1.3.0 published with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants