Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ecs-winston-format): fix expression in ambient context error #93

Merged
merged 4 commits into from
Aug 30, 2021

Conversation

danielmwakanema
Copy link
Contributor

This commit fixes #92.

- remove executable code in declaration file
- fix missing import error; Format is not exported from the winston root
…nt-ctx

fix(ecs-winston): remove expr from ambient ctx
refactor(ecs-format): use interop syntx for export
@cla-checker-service
Copy link

cla-checker-service bot commented Aug 28, 2021

💚 CLA has been signed

@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Aug 28, 2021
@apmmachine
Copy link
Contributor

apmmachine commented Aug 28, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-30T18:04:23.520+0000

  • Duration: 7 min 30 sec

  • Commit: 50017c0

Trends 🧪

Image of Build Times

@trentm trentm self-assigned this Aug 30, 2021
Copy link
Member

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks perfect, thanks! I feel bad I didn't catch this when the winston types went in originally.

@trentm trentm merged commit de8d7b8 into elastic:master Aug 30, 2021
@danielmwakanema
Copy link
Contributor Author

danielmwakanema commented Sep 3, 2021 via email

@trentm
Copy link
Member

trentm commented Sep 9, 2021

@danielmwakanema Sorry for the delay. Thanks for poking me on it. @elastic/ecs-winston-format@1.3.1 is published now.

@trentm
Copy link
Member

trentm commented Sep 9, 2021

Note that I have #96 in progress. I hope that doesn't break your TypeScript usage when I get that released.

@danielmwakanema
Copy link
Contributor Author

danielmwakanema commented Sep 9, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] ecs-winston-format not compiling due to expression in ambient context and missing import
3 participants