[RFC] FaaS Fields - Stage 0 #1518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 19, 2021
ebeahan
approved these changes
Jul 21, 2021
There was a problem hiding this comment.
Thanks, @AlexanderWert!
I left a few comments, but overall this is a great start to the proposal. It meets the criteria for stage 0 by summarizing the value these new fields could add to ECS.
Feel free to make changes to the content based on the feedback, but we can also carry those items forward and discuss more in the stage 1 PR.
rfcs/text/0000-faas-fields.md
Outdated
| faas.trigger.name | "POST /{proxy+}/Prod" | Human readable name of the trigger instance. | ||
| faas.trigger.id | `arn:aws:sqs:us-east-2:123456789012:my-queue` | The ID of the trigger instance (e.g. Api-ID, SQS-queue-ARN, etc.) | ||
| faas.trigger.request_id | e.g. `123456789` | The iD of the trigger request , message, event, etc. | ||
| faas.trigger.account.name | "SomeAccount" | The name of the account the trigger belongs to. |
There was a problem hiding this comment.
For cloud provider, account, and region information, could we re-use the existing cloud.* fields?
rfcs/text/0000-faas-fields.md
Outdated
|
|
||
| I'm proposing to add the following kind of fields: | ||
|
|
||
| Field | Example | Description |
There was a problem hiding this comment.
Not necessary for stage 0, but in later stages, a Type column listing the proposed data type of each field would be useful.
Co-authored-by: Eric Beahan <ebeahan@gmail.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you signed the contributor license agreement?
Have you followed the contributor guidelines?
For proposing substantial changes or additions to the schema, have you reviewed the RFC process?
If submitting code/script changes, have you verified all tests pass locally using
make test?If submitting schema/fields updates, have you generated new artifacts by running
makeand committed those changes?Is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
Have you added an entry to the CHANGELOG.next.md?