[npipe][fix] add a missing npipe import for windows #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VihasMakwana
added
bug
VihasMakwana
requested review from
michalpristas and
pchila
and removed request for
a team
💚 Build Succeeded
|
VihasMakwana
changed the title
ycombinator
requested review from
aleksmaus
and removed request for
michalpristas and
pchila
aleksmaus
approved these changes
Jul 12, 2024
ycombinator
requested review from
michalpristas
and removed request for
blakerouse
michalpristas
approved these changes
Jul 18, 2024
|
Builds ok, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#91 introduced
newNPipeListenerbut didn't add the import.- I think it wants to use the
github.com/elastic/elastic-agent-libs/api/npipelibrary. Correct me if I'm wrong @blakerouse / @aleksmausThis PR adds the missing import.