Revert removal of metrics-monitoring change, fix tests to account for fleet naming changes #4462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fearful-symmetry
added
Team:Elastic-Agent
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
|
This pull request does not have a backport label. Could you fix it @fearful-symmetry? 🙏
NOTE: |
cmacknz
reviewed
Mar 22, 2024
| } | ||
|
|
||
| func (runner *MetricsRunner) TestBeatsMetrics() { | ||
| UnitOutputName := "fleet-default-output" |
There was a problem hiding this comment.
Fleet reverted the change, it just isn't in the latest snapshot yet: elastic/kibana@3069efd
Don't merge until that happens or you'll just be undoing this again.
cmacknz
approved these changes
Mar 26, 2024
|
68.0% Coverage on New Code
0.0% Duplication on New Code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
reverts #4451 and changes the tests to account for recent changes in elastic/kibana#178857
We're not 100% sure if the change to name generation will remain, so the test is designed in such a way that we can make a 1-line change if the way kibana creates the output ID changes in the future.