Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(a11y): add label for screen readers #1121

Merged
merged 16 commits into from
Apr 22, 2021
Merged

feat(a11y): add label for screen readers #1121

merged 16 commits into from
Apr 22, 2021

Commits on Apr 14, 2021

  1. feat: add label for screen readers

    @rshen91
    rshen91 committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    1087852 View commit details
    Browse the repository at this point in the history

  2. test: update tests

    @rshen91
    rshen91 committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    4cb8ddc View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2021

  1. Merge remote-tracking branch 'upstream/master' into add-labels

    @rshen91
    rshen91 committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    e1c4fcd View commit details
    Browse the repository at this point in the history

  2. feat: add aria props

    @rshen91
    rshen91 committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    e20033a View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into add-labels

    @rshen91
    rshen91 committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    2612a2a View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2021

  1. test: add unit tests

    @rshen91
    rshen91 committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    a88737d View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2021

  1. feat: add code review feedback

    @rshen91
    rshen91 committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    19fb650 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into add-labels

    @rshen91
    rshen91 committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    d9f34a7 View commit details
    Browse the repository at this point in the history

  3. fix: update chart api

    @rshen91
    rshen91 committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    532bd0d View commit details
    Browse the repository at this point in the history

  4. fix: add code review feedback

    @rshen91
    rshen91 committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    356b754 View commit details
    Browse the repository at this point in the history

  5. chore: update chart api

    @rshen91
    rshen91 committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    e770e99 View commit details
    Browse the repository at this point in the history

  6. test: updated missed snapshot test

    @rshen91
    rshen91 committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    c1a9b8d View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2021

  1. fix: add idforchartseries types

    @rshen91
    rshen91 committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    6150d2d View commit details
    Browse the repository at this point in the history

  2. feat: remove aria-label

    @rshen91
    rshen91 committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    b81e6f8 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2021

  1. refactor(a11y): extract aria attributes in its own selector 

    This commit extracts all the Settings props related to accessibility into an internal configuration,
and reuse that configuration within the code without thinking about defaults"

BREAKING CHANGE: `description` prop in `<Settings/>` is renamed to `ariaDescription`
    @markov00
    markov00 committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    d757d9e View commit details
    Browse the repository at this point in the history

  2. test: update chart snap

    @rshen91
    rshen91 committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    deff638 View commit details
    Browse the repository at this point in the history