feat(metric): add value icon and color #2101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markov00
force-pushed
the
2023_07_11-add_value_icon_and_color
branch
from
2b79377
to
0f87bb6
Compare
markov00
changed the title
markov00
added
enhancement
|
buildkite update screenshots |
nickofthyme
approved these changes
Jul 17, 2023
nickofthyme
pushed a commit
that referenced
this pull request
Jul 19, 2023
# [59.1.0](v59.0.0...v59.1.0) (2023-07-19) ### Bug Fixes * **deps:** update dependency @elastic/eui to v83 ([#2088](#2088)) ([c72695e](c72695e)) * **deps:** update dependency @elastic/eui to v84 ([#2108](#2108)) ([2b76a9a](2b76a9a)) ### Features * **metric:** add value icon and color ([#2101](#2101)) ([d7134f5](d7134f5))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Expose two new props for the metric:
valueColoravailable on every MetricDatum, that allows you to customize the color used by the value labelvalueIconavailable on every MetricDatum, and that allows you to add an icon right to the value label. ThevalueIconreceive also the same color used by the value label.Issues
fix #2098
Checklist
:xy,:partition):interactions,:axis)closes #123,fixes #123)packages/charts/src/index.tsdark,light,eui-dark&eui-light