fix: graceful scale fallbacks and warnings

[nickofthyme]

Summary

fix #678

Adds x scale fallback to ScaleType.Ordinal when there is a non-numeric value found in the dataset. This includes a warning for y values that are not numeric values. The current functionality is to error.

Each X value in a linear x scale needs be be a number. Using ordinal x scale as fallback.

Adds warning for y values that are not parable into a numeric value.

Found non-numeric y values in dataset for spec "areas" ("a", "c")

Example

String value 'a' among numeric values, converts scale from linear to ordinal

Checklist

Delete any items that are not applicable to this PR.

• Any consumer-facing exports were added to src/index.ts (and stories only import from ../src except for test data & storybook)
• Proper documentation or storybook story was added for features that require explanation or tutorials
• Unit tests were updated or added to match the most common scenarios

[codecov-commenter]

Codecov Report

Merging #704 into master will increase coverage by 0.33%.
The diff coverage is 72.34%.

@@            Coverage Diff             @@
##           master     #704      +/-   ##
==========================================
+ Coverage   74.80%   75.14%   +0.33%     
==========================================
  Files         264      280      +16     
  Lines        8514     8846     +332     
  Branches     1709     1760      +51     
==========================================
+ Hits         6369     6647     +278     
- Misses       2093     2141      +48     
- Partials       52       58       +6     

Impacted Files	Coverage Δ
...ypes/partition_chart/renderer/canvas/partition.tsx	32.39% <ø> (ø)
src/utils/commons.ts	95.93% <ø> (-0.07%)	⬇️
src/utils/logger.ts	46.66% <46.66%> (ø)
src/state/chart_state.ts	87.09% <50.00%> (+0.21%)	⬆️
src/chart_types/xy_chart/domains/x_domain.ts	97.64% <71.42%> (-1.15%)	⬇️
src/chart_types/xy_chart/utils/series.ts	96.58% <88.88%> (-0.82%)	⬇️
src/chart_types/xy_chart/state/utils/utils.ts	92.95% <100.00%> (+0.50%)	⬆️
src/mocks/specs/specs.ts	74.71% <0.00%> (ø)
src/mocks/theme.ts	100.00% <0.00%> (ø)
src/mocks/specs/index.ts	100.00% <0.00%> (ø)
... and 13 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5f48f7...f587d6c. Read the comment docs.

[nickofthyme]

@markov00 I'm not sure about needed to have them separate. I think eventually the chart should error in dev to alert the developer of bad config then in prod only console.error severe issues.

I'll make the change for now and see if my opinion changes too.

see 5c42e8b

[markov00]

changes LGTM

[markov00]

🎉 This PR is included in version 19.5.1 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀