Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[system tests] Use datastream dataset if it exists #979

Merged
merged 3 commits into from
Sep 21, 2022

Conversation

klacabane
Copy link
Contributor

@klacabane klacabane commented Sep 16, 2022

Summary

The system tests didn't account for the overwriting dataset defined in a data stream's manifest.

For example the logstash.node data stream that overwrites the dataset fails with the following:

Error: error running package system tests: could not complete test run: could not add data stream config to policy: could not add package to policy; API status code = 500; response body = {"statusCode":500,"error":"Internal Server Error","message":"Stream template not found, unable to find dataset logstash.node"}

@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 16, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-20T21:00:05.303+0000

  • Duration: 33 min 53 sec

Test stats 🧪

Test Results
Failed 0
Passed 832
Skipped 0
Total 832

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 16, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (34/34) 💚
Files 66.929% (85/127) 👍
Classes 61.667% (111/180) 👍
Methods 49.044% (359/732) 👍 0.21
Lines 32.231% (3225/10006) 👍
Conditionals 100.0% (0/0) 💚

@klacabane klacabane added the Team:Ecosystem Label for the Packages Ecosystem team label Sep 16, 2022
@klacabane klacabane self-assigned this Sep 16, 2022
@klacabane klacabane marked this pull request as ready for review September 16, 2022 15:05
@klacabane klacabane changed the title use datastream dataset if it exists [system tests] Use datastream dataset if it exists Sep 16, 2022
@jsoriano
Copy link
Member

Change looks good, could you please add a package using dataset to test/packages? Thanks!

@jsoriano jsoriano requested a review from a team September 20, 2022 10:28
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@klacabane klacabane merged commit 4268f19 into elastic:main Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Ecosystem Label for the Packages Ecosystem team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants