Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix client usage of the Inference API #323

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

pquentin
Copy link
Member

I don't have an OpenAPI, so I can't actually test this. I would love help here.

Copy link

gitnotebooks bot commented Aug 30, 2024

Found 4 changed notebooks. Review the changes at https://app.gitnotebooks.com/elastic/elasticsearch-labs/pull/323

@pquentin
Copy link
Member Author

I now have an API key, and need to test the modified notebooks before merging.

@pquentin
Copy link
Member Author

I can confirm that the search notebooks all run fine now. I have not touched the other notebooks that use the Inference API.

This includes the Cohere integration (cc @szabosteve @maxhniebergall)

notebooks/integrations/cohere/cohere-elasticsearch.ipynb
notebooks/integrations/cohere/inference-cohere.ipynb
notebooks/integrations/cohere/updated-cohere-elasticsearch-inference-api.ipynb

And those blogs (cc @lio-p @llermaly):

supporting-blog-content/customer-success-example/ingest.py
supporting-blog-content/building-multilingual-rag-with-elastic-and-mistral/building_multilingual_rag_with_elastic_and_mistral.ipynb

@joemcelroy
Copy link
Member

great! thanks for that. Merge when you're ready.

@pquentin pquentin merged commit c68060c into elastic:main Aug 30, 2024
5 checks passed
@pquentin pquentin deleted the inference-model-id branch August 30, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants