Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] References shared/version and adds doctype to index file #1280

Merged
merged 2 commits into from
Feb 10, 2023

Conversation

szabosteve
Copy link
Contributor

@szabosteve szabosteve commented Feb 9, 2023

Overview

Related to https://github.com/elastic/clients-team/issues/532.

This PR references shared/version from the docs repo to make it possible to use the {branch} substitution, and adds doctype: book to the index file. It also changes a link to use {branch} instead of master.

@szabosteve szabosteve changed the title [DOCS] Adds doctype to index file. [DOCS] References shared/version and adds doctype to index file Feb 9, 2023
@szabosteve szabosteve marked this pull request as ready for review February 10, 2023 08:30
Copy link
Contributor

@ezimuel ezimuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Some tests are failing but they are not related to this PR.

@szabosteve
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.7

Questions ?

Please refer to the Backport tool documentation

szabosteve added a commit to szabosteve/elasticsearch-php that referenced this pull request Feb 10, 2023
…tic#1280)

* [DOCS] Adds doctype to index file.

* [DOCS] Adds shared/versions to include in index.

(cherry picked from commit d0df2ef)
szabosteve added a commit to szabosteve/elasticsearch-php that referenced this pull request Feb 10, 2023
…tic#1280)

* [DOCS] Adds doctype to index file.

* [DOCS] Adds shared/versions to include in index.
szabosteve added a commit to szabosteve/elasticsearch-php that referenced this pull request Feb 10, 2023
…tic#1280)

* [DOCS] Adds doctype to index file.

* [DOCS] Adds shared/versions to include in index.
szabosteve added a commit to szabosteve/elasticsearch-php that referenced this pull request Feb 10, 2023
…tic#1280)

* [DOCS] Adds doctype to index file.

* [DOCS] Adds shared/versions to include in index.
szabosteve added a commit to szabosteve/elasticsearch-php that referenced this pull request Feb 10, 2023
…tic#1280)

* [DOCS] Adds doctype to index file.

* [DOCS] Adds shared/versions to include in index.
szabosteve added a commit to szabosteve/elasticsearch-php that referenced this pull request Feb 10, 2023
…tic#1280)

* [DOCS] Adds doctype to index file.

* [DOCS] Adds shared/versions to include in index.
szabosteve added a commit to szabosteve/elasticsearch-php that referenced this pull request Feb 10, 2023
…tic#1280)

* [DOCS] Adds doctype to index file.

* [DOCS] Adds shared/versions to include in index.
szabosteve added a commit to szabosteve/elasticsearch-php that referenced this pull request Feb 10, 2023
…tic#1280)

* [DOCS] Adds doctype to index file.

* [DOCS] Adds shared/versions to include in index.
szabosteve added a commit to szabosteve/elasticsearch-php that referenced this pull request Feb 10, 2023
…tic#1280)

* [DOCS] Adds doctype to index file.

* [DOCS] Adds shared/versions to include in index.
szabosteve added a commit to szabosteve/elasticsearch-php that referenced this pull request Feb 10, 2023
…tic#1280)

* [DOCS] Adds doctype to index file.

* [DOCS] Adds shared/versions to include in index.
szabosteve added a commit to szabosteve/elasticsearch-php that referenced this pull request Feb 10, 2023
…tic#1280)

* [DOCS] Adds doctype to index file.

* [DOCS] Adds shared/versions to include in index.
ezimuel pushed a commit that referenced this pull request Feb 10, 2023
… (#1281)

* [DOCS] Adds doctype to index file.

* [DOCS] Adds shared/versions to include in index.

(cherry picked from commit d0df2ef)
ezimuel pushed a commit that referenced this pull request Feb 10, 2023
… (#1282)

* [DOCS] Adds doctype to index file.

* [DOCS] Adds shared/versions to include in index.
ezimuel pushed a commit that referenced this pull request Feb 10, 2023
… (#1283)

* [DOCS] Adds doctype to index file.

* [DOCS] Adds shared/versions to include in index.
ezimuel pushed a commit that referenced this pull request Feb 10, 2023
… (#1284)

* [DOCS] Adds doctype to index file.

* [DOCS] Adds shared/versions to include in index.
ezimuel pushed a commit that referenced this pull request Feb 10, 2023
… (#1288)

* [DOCS] Adds doctype to index file.

* [DOCS] Adds shared/versions to include in index.
ezimuel pushed a commit that referenced this pull request Feb 13, 2023
…#1280)  (#1291)

* [DOCS] References shared/version and adds doctype to index file (#1280)

* [DOCS] Adds doctype to index file.

* [DOCS] Adds shared/versions to include in index.

* [DOCS] Fixes link in community integrations.

* Apply suggestions from code review

* Apply suggestions from code review
ezimuel pushed a commit that referenced this pull request Feb 13, 2023
…#1280) (#1290)

* [DOCS] References shared/version and adds doctype to index file (#1280)

* [DOCS] Adds doctype to index file.

* [DOCS] Adds shared/versions to include in index.

* [DOCS] Fixes link in community integrations.

* Apply suggestions from code review
ezimuel pushed a commit that referenced this pull request Feb 13, 2023
…1280)  (#1289)

* [DOCS] References shared/version and adds doctype to index file (#1280)

* [DOCS] Adds doctype to index file.

* [DOCS] Adds shared/versions to include in index.

* [DOCS] Fixes link in community integrations.

* Apply suggestions from code review
ezimuel pushed a commit that referenced this pull request Feb 13, 2023
… (#1287)

* [DOCS] Adds doctype to index file.

* [DOCS] Adds shared/versions to include in index.
ezimuel pushed a commit that referenced this pull request Feb 13, 2023
… (#1286)

* [DOCS] Adds doctype to index file.

* [DOCS] Adds shared/versions to include in index.
ezimuel pushed a commit that referenced this pull request Feb 14, 2023
… (#1285)

* [DOCS] Adds doctype to index file.

* [DOCS] Adds shared/versions to include in index.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants