Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow plugin for php-http/discovery library #1294

Merged

Conversation

hkulekci
Copy link
Contributor

According to this change of php-http/discovery library, we need to allow the plugin on composer.json. So I initialize this PR to add this.

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@hkulekci
Copy link
Contributor Author

hkulekci commented Feb 12, 2023

So, we are using elasticsearch client in this library: matchish/laravel-scout-elasticsearch#230
The plugin error occurred while running the tests. You can check here: https://github.com/matchish/laravel-scout-elasticsearch/actions/runs/4156971917/jobs/7191125500

ping @ezimuel

@hkulekci hkulekci force-pushed the allow-plugin-for-php-http-discovery-library branch from 5231208 to 6906d3f Compare February 13, 2023 05:45
@hkulekci
Copy link
Contributor Author

Let me rebase to main. @ezimuel

@hkulekci hkulekci force-pushed the allow-plugin-for-php-http-discovery-library branch from 6906d3f to c3b38a0 Compare February 13, 2023 08:27
@hkulekci
Copy link
Contributor Author

Rebased to main after this change.

@ezimuel
Copy link
Contributor

ezimuel commented Feb 13, 2023

Thanks @hkulekci

@hkulekci
Copy link
Contributor Author

hkulekci commented Feb 13, 2023

I don't know why the test gives an error for the docker snapshot. I thought that "Unified Release Manager Check" would give an output for the following workflows. But also, tests are looking for docker.elastic.co/elasticsearch/elasticsearch:8.8-SNAPSHOT. And this snapshot is not available in https://www.docker.elastic.co/r/elasticsearch even.

Unable to find image 'docker.elastic.co/elasticsearch/elasticsearch:8.8-SNAPSHOT' locally

I could not follow the all PRs recently. Is this error typical, or known issue

@ezimuel
Copy link
Contributor

ezimuel commented Feb 13, 2023

@hkulekci the error is fine :-) This is because we don't have a 8.8-SNAPSHOT artifact yet. I'm working to fix the other CI errors, like this one.

@hkulekci
Copy link
Contributor Author

hkulekci commented Feb 13, 2023

Ah okay. Thanks. ✌️ That error is interesting, too. There is no explanation on raw logs why the operation was canceled, even. I thought that all the other tests were forced to skip/cancel if one of them got an error. Because there is no explanation on raw logs too :

2023-02-13T08:29:28.7213113Z ##[endgroup]
2023-02-13T08:29:29.3417621Z > phpstan analyse src --level 2 --no-progress
2023-02-13T08:29:29.6421715Z 
2023-02-13T08:29:29.6463535Z  ! [NOTE] The Xdebug PHP extension is active, but "--xdebug" is not used. This  
2023-02-13T08:29:29.6464319Z  !        may slow down performance and the process will not halt at            
2023-02-13T08:29:29.6465170Z  !        breakpoints.                                                          
2023-02-13T08:29:29.6465581Z 
2023-02-13T08:29:29.9189462Z Note: Using configuration file /home/runner/work/elasticsearch-php/elasticsearch-php/phpstan.neon.
2023-02-13T08:29:37.3967314Z 
2023-02-13T08:29:37.3994579Z  [OK] No errors                                                                 
2023-02-13T08:29:37.4000209Z 
2023-02-13T08:29:37.4825999Z ##[error]The operation was canceled.       <---------
2023-02-13T08:29:37.4902235Z Post job cleanup.
2023-02-13T08:29:37.6301073Z [command]/usr/bin/git version
2023-02-13T08:29:37.6355728Z git version 2.39.1

@ezimuel
Copy link
Contributor

ezimuel commented Feb 13, 2023

@hkulekci I tried to remove xdebug in PHP used by the test. Can you rebase from main? Thanks.

@hkulekci hkulekci force-pushed the allow-plugin-for-php-http-discovery-library branch from c3b38a0 to a8f67c1 Compare February 13, 2023 13:59
@hkulekci
Copy link
Contributor Author

@ezimuel Done!

@ezimuel ezimuel merged commit 9a734ac into elastic:main Feb 13, 2023
github-actions bot pushed a commit that referenced this pull request Feb 13, 2023
github-actions bot pushed a commit that referenced this pull request Feb 13, 2023
@ezimuel
Copy link
Contributor

ezimuel commented Feb 13, 2023

Thanks @hkulekci for your contribution.

@hkulekci hkulekci deleted the allow-plugin-for-php-http-discovery-library branch February 13, 2023 15:33
ezimuel pushed a commit that referenced this pull request Feb 14, 2023
(cherry picked from commit 9a734ac)

Co-authored-by: Haydar KÜLEKCİ <586318+hkulekci@users.noreply.github.com>
ezimuel pushed a commit that referenced this pull request Feb 14, 2023
(cherry picked from commit 9a734ac)

Co-authored-by: Haydar KÜLEKCİ <586318+hkulekci@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants