-
Notifications
You must be signed in to change notification settings - Fork 965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow plugin for php-http/discovery library #1294
allow plugin for php-http/discovery library #1294
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
So, we are using elasticsearch client in this library: matchish/laravel-scout-elasticsearch#230 ping @ezimuel |
5231208
to
6906d3f
Compare
Let me rebase to main. @ezimuel |
6906d3f
to
c3b38a0
Compare
Rebased to main after this change. |
Thanks @hkulekci |
I don't know why the test gives an error for the docker snapshot. I thought that "Unified Release Manager Check" would give an output for the following workflows. But also, tests are looking for
I could not follow the all PRs recently. Is this error typical, or known issue |
Ah okay. Thanks. ✌️ That error is interesting, too. There is no explanation on raw logs why the operation was canceled, even. I thought that all the other tests were forced to skip/cancel if one of them got an error. Because there is no explanation on raw logs too :
|
@hkulekci I tried to remove xdebug in PHP used by the test. Can you rebase from main? Thanks. |
c3b38a0
to
a8f67c1
Compare
@ezimuel Done! |
(cherry picked from commit 9a734ac)
(cherry picked from commit 9a734ac)
Thanks @hkulekci for your contribution. |
According to this change of php-http/discovery library, we need to allow the plugin on composer.json. So I initialize this PR to add this.