Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added User-Agent #898

Merged
merged 3 commits into from
Jun 13, 2019
Merged

Added User-Agent #898

merged 3 commits into from
Jun 13, 2019

Conversation

ezimuel
Copy link
Contributor

@ezimuel ezimuel commented Jun 12, 2019

This PR adds the User-Agent header in the HTTP request, with the format:

<client-repo-name>/<client-version> (metadata-values)

where as the client-repo-name defines the repository name of the client e.g. elasticsearch-js and the client-version the current version of this client.

metadata-values is a list of semicolon seperated key-values, that allow to add more data enclosed by brackets (()). Each key-value pair is separated by a whitespace, e.g. PHP 7.3.6
In case no metadata is appended at all, the brackets must be omited.

@ezimuel ezimuel added this to the 7.0.0 milestone Jun 12, 2019
@ezimuel ezimuel requested a review from philkra June 12, 2019 15:17
Copy link
Contributor

@philkra philkra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ezimuel ezimuel merged commit e12e308 into elastic:master Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants