Derive Clone on Bulk request structs #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
💚 CLA has been signed |
|
i signed the CLA but not sure github is being updated properly |
|
oh there we go |
|
Hi @russcam - any interest in this change? |
|
Hey @jefftt, I no longer work for Elastic so no longer have access rights to this repository to work with you on this PR. Perhaps @swallez or @sethmlarson can work with you to get this in? |
swallez
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #195
This option is the least invasive as it doesn't change the type signatures although it requires extra allocations in order to clone the struct. Allowing
bodyto take a reference to a slice of operations instead of ownership would be a more efficient solution that could be addressed in a separate PR