Revert canTripCircuitBreaker change

No need for callers to specify `canTripCircuitBreaker`, the default for this is safe.
elastic · Oct 3, 2023 · 0f18e27 · 0f18e27
1 parent df45d4b
commit 0f18e27
Show file tree

Hide file tree

Showing 180 changed files with 95 additions and 420 deletions.
diff --git a/...ugin/src/main/java/org/elasticsearch/plugin/noop/action/bulk/TransportNoopBulkAction.java b/...ugin/src/main/java/org/elasticsearch/plugin/noop/action/bulk/TransportNoopBulkAction.java
@@ -31,7 +31,7 @@ public class TransportNoopBulkAction extends HandledTransportAction<BulkRequest,
 
     @Inject
     public TransportNoopBulkAction(TransportService transportService, ActionFilters actionFilters) {
-        super(NoopBulkAction.NAME, true, transportService, actionFilters, BulkRequest::new, EsExecutors.DIRECT_EXECUTOR_SERVICE);
+        super(NoopBulkAction.NAME, transportService, actionFilters, BulkRequest::new, EsExecutors.DIRECT_EXECUTOR_SERVICE);
     }
 
     @Override

diff --git a/.../src/main/java/org/elasticsearch/plugin/noop/action/search/TransportNoopSearchAction.java b/.../src/main/java/org/elasticsearch/plugin/noop/action/search/TransportNoopSearchAction.java
@@ -33,7 +33,6 @@ public class TransportNoopSearchAction extends HandledTransportAction<SearchRequ
     public TransportNoopSearchAction(TransportService transportService, ActionFilters actionFilters) {
         super(
             NoopSearchAction.NAME,
-            true,
             transportService,
             actionFilters,
             (Writeable.Reader<SearchRequest>) SearchRequest::new,

diff --git a/...s/ingest-common/src/main/java/org/elasticsearch/ingest/common/GrokProcessorGetAction.java b/...s/ingest-common/src/main/java/org/elasticsearch/ingest/common/GrokProcessorGetAction.java
@@ -140,7 +140,7 @@ public TransportAction(TransportService transportService, ActionFilters actionFi
             PatternBank legacyGrokPatterns,
             PatternBank ecsV1GrokPatterns
         ) {
-            super(NAME, true, transportService, actionFilters, Request::new, EsExecutors.DIRECT_EXECUTOR_SERVICE);
+            super(NAME, transportService, actionFilters, Request::new, EsExecutors.DIRECT_EXECUTOR_SERVICE);
             this.legacyGrokPatterns = legacyGrokPatterns.bank();
             this.sortedLegacyGrokPatterns = new TreeMap<>(this.legacyGrokPatterns);
             this.ecsV1GrokPatterns = ecsV1GrokPatterns.bank();

diff --git a/...e/src/main/java/org/elasticsearch/script/mustache/TransportMultiSearchTemplateAction.java b/...e/src/main/java/org/elasticsearch/script/mustache/TransportMultiSearchTemplateAction.java
@@ -47,7 +47,6 @@ public TransportMultiSearchTemplateAction(
     ) {
         super(
             MultiSearchTemplateAction.NAME,
-            true,
             transportService,
             actionFilters,
             MultiSearchTemplateRequest::new,

diff --git a/...stache/src/main/java/org/elasticsearch/script/mustache/TransportSearchTemplateAction.java b/...stache/src/main/java/org/elasticsearch/script/mustache/TransportSearchTemplateAction.java
@@ -55,14 +55,7 @@ public TransportSearchTemplateAction(
         NodeClient client,
         UsageService usageService
     ) {
-        super(
-            SearchTemplateAction.NAME,
-            true,
-            transportService,
-            actionFilters,
-            SearchTemplateRequest::new,
-            EsExecutors.DIRECT_EXECUTOR_SERVICE
-        );
+        super(SearchTemplateAction.NAME, transportService, actionFilters, SearchTemplateRequest::new, EsExecutors.DIRECT_EXECUTOR_SERVICE);
         this.scriptService = scriptService;
         this.xContentRegistry = xContentRegistry;
         this.client = client;

diff --git a/.../lang-painless/src/main/java/org/elasticsearch/painless/action/PainlessContextAction.java b/.../lang-painless/src/main/java/org/elasticsearch/painless/action/PainlessContextAction.java
@@ -143,14 +143,7 @@ public static class TransportAction extends HandledTransportAction<Request, Resp
 
         @Inject
         public TransportAction(TransportService transportService, ActionFilters actionFilters, PainlessScriptEngine painlessScriptEngine) {
-            super(
-                NAME,
-                true,
-                transportService,
-                actionFilters,
-                (Writeable.Reader<Request>) Request::new,
-                EsExecutors.DIRECT_EXECUTOR_SERVICE
-            );
+            super(NAME, transportService, actionFilters, (Writeable.Reader<Request>) Request::new, EsExecutors.DIRECT_EXECUTOR_SERVICE);
             this.painlessScriptEngine = painlessScriptEngine;
         }
 

diff --git a/...les/rank-eval/src/main/java/org/elasticsearch/index/rankeval/TransportRankEvalAction.java b/...les/rank-eval/src/main/java/org/elasticsearch/index/rankeval/TransportRankEvalAction.java
@@ -70,7 +70,7 @@ public TransportRankEvalAction(
         ScriptService scriptService,
         NamedXContentRegistry namedXContentRegistry
     ) {
-        super(RankEvalAction.NAME, true, transportService, actionFilters, RankEvalRequest::new, EsExecutors.DIRECT_EXECUTOR_SERVICE);
+        super(RankEvalAction.NAME, transportService, actionFilters, RankEvalRequest::new, EsExecutors.DIRECT_EXECUTOR_SERVICE);
         this.scriptService = scriptService;
         this.namedXContentRegistry = namedXContentRegistry;
         this.client = client;

diff --git a/modules/reindex/src/main/java/org/elasticsearch/reindex/TransportDeleteByQueryAction.java b/modules/reindex/src/main/java/org/elasticsearch/reindex/TransportDeleteByQueryAction.java
@@ -41,14 +41,7 @@ public TransportDeleteByQueryAction(
         ScriptService scriptService,
         ClusterService clusterService
     ) {
-        super(
-            DeleteByQueryAction.NAME,
-            true,
-            transportService,
-            actionFilters,
-            DeleteByQueryRequest::new,
-            EsExecutors.DIRECT_EXECUTOR_SERVICE
-        );
+        super(DeleteByQueryAction.NAME, transportService, actionFilters, DeleteByQueryRequest::new, EsExecutors.DIRECT_EXECUTOR_SERVICE);
         this.threadPool = threadPool;
         this.client = client;
         this.scriptService = scriptService;

diff --git a/modules/reindex/src/main/java/org/elasticsearch/reindex/TransportReindexAction.java b/modules/reindex/src/main/java/org/elasticsearch/reindex/TransportReindexAction.java
@@ -83,7 +83,7 @@ protected TransportReindexAction(
         TransportService transportService,
         ReindexSslConfig sslConfig
     ) {
-        super(name, true, transportService, actionFilters, ReindexRequest::new, EsExecutors.DIRECT_EXECUTOR_SERVICE);
+        super(name, transportService, actionFilters, ReindexRequest::new, EsExecutors.DIRECT_EXECUTOR_SERVICE);
         this.client = client;
         this.reindexValidator = new ReindexValidator(settings, clusterService, indexNameExpressionResolver, autoCreateIndex);
         this.reindexer = new Reindexer(clusterService, client, threadPool, scriptService, sslConfig);

diff --git a/modules/reindex/src/main/java/org/elasticsearch/reindex/TransportUpdateByQueryAction.java b/modules/reindex/src/main/java/org/elasticsearch/reindex/TransportUpdateByQueryAction.java
@@ -54,14 +54,7 @@ public TransportUpdateByQueryAction(
         ScriptService scriptService,
         ClusterService clusterService
     ) {
-        super(
-            UpdateByQueryAction.NAME,
-            true,
-            transportService,
-            actionFilters,
-            UpdateByQueryRequest::new,
-            EsExecutors.DIRECT_EXECUTOR_SERVICE
-        );
+        super(UpdateByQueryAction.NAME, transportService, actionFilters, UpdateByQueryRequest::new, EsExecutors.DIRECT_EXECUTOR_SERVICE);
         this.threadPool = threadPool;
         this.client = client;
         this.scriptService = scriptService;

diff --git a/modules/rest-root/src/main/java/org/elasticsearch/rest/root/TransportMainAction.java b/modules/rest-root/src/main/java/org/elasticsearch/rest/root/TransportMainAction.java
@@ -34,7 +34,7 @@ public TransportMainAction(
         ActionFilters actionFilters,
         ClusterService clusterService
     ) {
-        super(MainAction.NAME, true, transportService, actionFilters, MainRequest::new, EsExecutors.DIRECT_EXECUTOR_SERVICE);
+        super(MainAction.NAME, transportService, actionFilters, MainRequest::new, EsExecutors.DIRECT_EXECUTOR_SERVICE);
         this.nodeName = Node.NODE_NAME_SETTING.get(settings);
         this.clusterService = clusterService;
     }

diff --git a/...rc/internalClusterTest/java/org/elasticsearch/action/admin/cluster/tasks/ListTasksIT.java b/...rc/internalClusterTest/java/org/elasticsearch/action/admin/cluster/tasks/ListTasksIT.java
@@ -186,7 +186,7 @@ public TestTransportAction(
             PluginsService pluginsService,
             ThreadPool threadPool
         ) {
-            super(NAME, true, transportService, actionFilters, in -> new TestRequest(), EsExecutors.DIRECT_EXECUTOR_SERVICE);
+            super(NAME, transportService, actionFilters, in -> new TestRequest(), EsExecutors.DIRECT_EXECUTOR_SERVICE);
             testPlugin = pluginsService.filterPlugins(TestPlugin.class).get(0);
             this.threadPool = threadPool;
         }

diff --git a/...rc/main/java/org/elasticsearch/action/admin/cluster/coordination/MasterHistoryAction.java b/...rc/main/java/org/elasticsearch/action/admin/cluster/coordination/MasterHistoryAction.java
@@ -130,7 +130,7 @@ public static class TransportAction extends HandledTransportAction<Request, Resp
 
         @Inject
         public TransportAction(TransportService transportService, ActionFilters actionFilters, MasterHistoryService masterHistoryService) {
-            super(MasterHistoryAction.NAME, true, transportService, actionFilters, Request::new, EsExecutors.DIRECT_EXECUTOR_SERVICE);
+            super(MasterHistoryAction.NAME, transportService, actionFilters, Request::new, EsExecutors.DIRECT_EXECUTOR_SERVICE);
             this.masterHistoryService = masterHistoryService;
         }
 

diff --git a/...in/java/org/elasticsearch/action/admin/cluster/node/tasks/get/TransportGetTaskAction.java b/...in/java/org/elasticsearch/action/admin/cluster/node/tasks/get/TransportGetTaskAction.java
@@ -76,7 +76,7 @@ public TransportGetTaskAction(
         Client client,
         NamedXContentRegistry xContentRegistry
     ) {
-        super(GetTaskAction.NAME, true, transportService, actionFilters, GetTaskRequest::new, EsExecutors.DIRECT_EXECUTOR_SERVICE);
+        super(GetTaskAction.NAME, transportService, actionFilters, GetTaskRequest::new, EsExecutors.DIRECT_EXECUTOR_SERVICE);
         this.threadPool = threadPool;
         this.clusterService = clusterService;
         this.transportService = transportService;

diff --git a/...src/main/java/org/elasticsearch/action/admin/cluster/remote/RemoteClusterNodesAction.java b/...src/main/java/org/elasticsearch/action/admin/cluster/remote/RemoteClusterNodesAction.java
@@ -99,7 +99,7 @@ public static class TransportAction extends HandledTransportAction<Request, Resp
 
         @Inject
         public TransportAction(TransportService transportService, ActionFilters actionFilters) {
-            super(RemoteClusterNodesAction.NAME, true, transportService, actionFilters, Request::new, EsExecutors.DIRECT_EXECUTOR_SERVICE);
+            super(RemoteClusterNodesAction.NAME, transportService, actionFilters, Request::new, EsExecutors.DIRECT_EXECUTOR_SERVICE);
             this.transportService = transportService;
         }
 

diff --git a/...rc/main/java/org/elasticsearch/action/admin/cluster/remote/TransportRemoteInfoAction.java b/...rc/main/java/org/elasticsearch/action/admin/cluster/remote/TransportRemoteInfoAction.java
@@ -31,7 +31,7 @@ public TransportRemoteInfoAction(
         ActionFilters actionFilters,
         SearchTransportService searchTransportService
     ) {
-        super(RemoteInfoAction.NAME, true, transportService, actionFilters, RemoteInfoRequest::new, EsExecutors.DIRECT_EXECUTOR_SERVICE);
+        super(RemoteInfoAction.NAME, transportService, actionFilters, RemoteInfoRequest::new, EsExecutors.DIRECT_EXECUTOR_SERVICE);
         this.remoteClusterService = searchTransportService.getRemoteClusterService();
     }
 

diff --git a/...org/elasticsearch/action/admin/cluster/storedscripts/TransportGetScriptContextAction.java b/...org/elasticsearch/action/admin/cluster/storedscripts/TransportGetScriptContextAction.java
@@ -27,7 +27,6 @@ public class TransportGetScriptContextAction extends HandledTransportAction<GetS
     public TransportGetScriptContextAction(TransportService transportService, ActionFilters actionFilters, ScriptService scriptService) {
         super(
             GetScriptContextAction.NAME,
-            true,
             transportService,
             actionFilters,
             GetScriptContextRequest::new,

diff --git a/...rg/elasticsearch/action/admin/cluster/storedscripts/TransportGetScriptLanguageAction.java b/...rg/elasticsearch/action/admin/cluster/storedscripts/TransportGetScriptLanguageAction.java
@@ -24,7 +24,6 @@ public class TransportGetScriptLanguageAction extends HandledTransportAction<Get
     public TransportGetScriptLanguageAction(TransportService transportService, ActionFilters actionFilters, ScriptService scriptService) {
         super(
             GetScriptLanguageAction.NAME,
-            true,
             transportService,
             actionFilters,
             GetScriptLanguageRequest::new,

diff --git a/...search/action/admin/indices/dangling/import_index/TransportImportDanglingIndexAction.java b/...search/action/admin/indices/dangling/import_index/TransportImportDanglingIndexAction.java
@@ -52,7 +52,6 @@ public TransportImportDanglingIndexAction(
     ) {
         super(
             ImportDanglingIndexAction.NAME,
-            true,
             transportService,
             actionFilters,
             ImportDanglingIndexRequest::new,

diff --git a/...a/org/elasticsearch/action/admin/indices/mapping/get/TransportGetFieldMappingsAction.java b/...a/org/elasticsearch/action/admin/indices/mapping/get/TransportGetFieldMappingsAction.java
@@ -44,7 +44,6 @@ public TransportGetFieldMappingsAction(
     ) {
         super(
             GetFieldMappingsAction.NAME,
-            true,
             transportService,
             actionFilters,
             GetFieldMappingsRequest::new,

diff --git a/server/src/main/java/org/elasticsearch/action/admin/indices/resolve/ResolveIndexAction.java b/server/src/main/java/org/elasticsearch/action/admin/indices/resolve/ResolveIndexAction.java
@@ -454,7 +454,7 @@ public TransportAction(
             ActionFilters actionFilters,
             IndexNameExpressionResolver indexNameExpressionResolver
         ) {
-            super(NAME, true, transportService, actionFilters, Request::new, EsExecutors.DIRECT_EXECUTOR_SERVICE);
+            super(NAME, transportService, actionFilters, Request::new, EsExecutors.DIRECT_EXECUTOR_SERVICE);
             this.threadPool = threadPool;
             this.clusterService = clusterService;
             this.remoteClusterService = transportService.getRemoteClusterService();

diff --git a/server/src/main/java/org/elasticsearch/action/bulk/TransportSingleItemBulkWriteAction.java b/server/src/main/java/org/elasticsearch/action/bulk/TransportSingleItemBulkWriteAction.java
@@ -39,7 +39,7 @@ protected TransportSingleItemBulkWriteAction(
         Writeable.Reader<Request> requestReader,
         TransportBulkAction bulkAction
     ) {
-        super(actionName, true, transportService, actionFilters, requestReader, EsExecutors.DIRECT_EXECUTOR_SERVICE);
+        super(actionName, transportService, actionFilters, requestReader, EsExecutors.DIRECT_EXECUTOR_SERVICE);
         this.bulkAction = bulkAction;
     }
 

diff --git a/server/src/main/java/org/elasticsearch/action/get/TransportMultiGetAction.java b/server/src/main/java/org/elasticsearch/action/get/TransportMultiGetAction.java
@@ -45,7 +45,7 @@ public TransportMultiGetAction(
         IndexNameExpressionResolver resolver,
         IndicesService indicesService
     ) {
-        super(MultiGetAction.NAME, true, transportService, actionFilters, MultiGetRequest::new, EsExecutors.DIRECT_EXECUTOR_SERVICE);
+        super(MultiGetAction.NAME, transportService, actionFilters, MultiGetRequest::new, EsExecutors.DIRECT_EXECUTOR_SERVICE);
         this.clusterService = clusterService;
         this.client = client;
         this.indexNameExpressionResolver = resolver;

diff --git a/server/src/main/java/org/elasticsearch/action/ingest/SimulatePipelineTransportAction.java b/server/src/main/java/org/elasticsearch/action/ingest/SimulatePipelineTransportAction.java
@@ -61,7 +61,6 @@ public SimulatePipelineTransportAction(
     ) {
         super(
             SimulatePipelineAction.NAME,
-            true,
             transportService,
             actionFilters,
             SimulatePipelineRequest::new,

diff --git a/server/src/main/java/org/elasticsearch/action/search/TransportClearScrollAction.java b/server/src/main/java/org/elasticsearch/action/search/TransportClearScrollAction.java
@@ -29,7 +29,7 @@ public TransportClearScrollAction(
         ActionFilters actionFilters,
         SearchTransportService searchTransportService
     ) {
-        super(ClearScrollAction.NAME, true, transportService, actionFilters, ClearScrollRequest::new, EsExecutors.DIRECT_EXECUTOR_SERVICE);
+        super(ClearScrollAction.NAME, transportService, actionFilters, ClearScrollRequest::new, EsExecutors.DIRECT_EXECUTOR_SERVICE);
         this.clusterService = clusterService;
         this.searchTransportService = searchTransportService;
     }

diff --git a/server/src/main/java/org/elasticsearch/action/search/TransportClosePointInTimeAction.java b/server/src/main/java/org/elasticsearch/action/search/TransportClosePointInTimeAction.java
@@ -36,7 +36,6 @@ public TransportClosePointInTimeAction(
     ) {
         super(
             ClosePointInTimeAction.NAME,
-            true,
             transportService,
             actionFilters,
             ClosePointInTimeRequest::new,

diff --git a/server/src/main/java/org/elasticsearch/action/search/TransportMultiSearchAction.java b/server/src/main/java/org/elasticsearch/action/search/TransportMultiSearchAction.java
@@ -49,7 +49,6 @@ public TransportMultiSearchAction(
     ) {
         super(
             MultiSearchAction.NAME,
-            true,
             transportService,
             actionFilters,
             (Writeable.Reader<MultiSearchRequest>) MultiSearchRequest::new,
@@ -73,7 +72,6 @@ public TransportMultiSearchAction(
     ) {
         super(
             MultiSearchAction.NAME,
-            true,
             transportService,
             actionFilters,
             (Writeable.Reader<MultiSearchRequest>) MultiSearchRequest::new,

diff --git a/server/src/main/java/org/elasticsearch/action/search/TransportOpenPointInTimeAction.java b/server/src/main/java/org/elasticsearch/action/search/TransportOpenPointInTimeAction.java
@@ -64,7 +64,6 @@ public TransportOpenPointInTimeAction(
     ) {
         super(
             OpenPointInTimeAction.NAME,
-            true,
             transportService,
             actionFilters,
             OpenPointInTimeRequest::new,

diff --git a/server/src/main/java/org/elasticsearch/action/search/TransportSearchAction.java b/server/src/main/java/org/elasticsearch/action/search/TransportSearchAction.java
@@ -161,7 +161,6 @@ public TransportSearchAction(
     ) {
         super(
             SearchAction.NAME,
-            true,
             transportService,
             actionFilters,
             (Writeable.Reader<SearchRequest>) SearchRequest::new,

diff --git a/server/src/main/java/org/elasticsearch/action/search/TransportSearchScrollAction.java b/server/src/main/java/org/elasticsearch/action/search/TransportSearchScrollAction.java
@@ -33,14 +33,7 @@ public TransportSearchScrollAction(
         ActionFilters actionFilters,
         SearchTransportService searchTransportService
     ) {
-        super(
-            SearchScrollAction.NAME,
-            true,
-            transportService,
-            actionFilters,
-            SearchScrollRequest::new,
-            EsExecutors.DIRECT_EXECUTOR_SERVICE
-        );
+        super(SearchScrollAction.NAME, transportService, actionFilters, SearchScrollRequest::new, EsExecutors.DIRECT_EXECUTOR_SERVICE);
         this.clusterService = clusterService;
         this.searchTransportService = searchTransportService;
     }

diff --git a/server/src/main/java/org/elasticsearch/action/support/HandledTransportAction.java b/server/src/main/java/org/elasticsearch/action/support/HandledTransportAction.java
@@ -32,7 +32,7 @@ protected HandledTransportAction(
         ActionFilters actionFilters,
         Writeable.Reader<Request> requestReader
     ) {
-        this(actionName, true, transportService, actionFilters, requestReader, EsExecutors.DIRECT_EXECUTOR_SERVICE);
+        this(actionName, transportService, actionFilters, requestReader, EsExecutors.DIRECT_EXECUTOR_SERVICE);
     }
 
     protected HandledTransportAction(

diff --git a/.../main/java/org/elasticsearch/action/support/ReservedStateAwareHandledTransportAction.java b/.../main/java/org/elasticsearch/action/support/ReservedStateAwareHandledTransportAction.java
@@ -35,7 +35,7 @@ protected ReservedStateAwareHandledTransportAction(
         ActionFilters actionFilters,
         Writeable.Reader<Request> requestReader
     ) {
-        super(actionName, true, transportService, actionFilters, requestReader, EsExecutors.DIRECT_EXECUTOR_SERVICE);
+        super(actionName, transportService, actionFilters, requestReader, EsExecutors.DIRECT_EXECUTOR_SERVICE);
         this.clusterService = clusterService;
     }
 

diff --git a/...ticsearch/action/support/broadcast/unpromotable/TransportBroadcastUnpromotableAction.java b/...ticsearch/action/support/broadcast/unpromotable/TransportBroadcastUnpromotableAction.java
@@ -54,7 +54,7 @@ protected TransportBroadcastUnpromotableAction(
         Writeable.Reader<Request> requestReader,
         Executor executor
     ) {
-        super(actionName, true, transportService, actionFilters, requestReader, EsExecutors.DIRECT_EXECUTOR_SERVICE);
+        super(actionName, transportService, actionFilters, requestReader, EsExecutors.DIRECT_EXECUTOR_SERVICE);
         this.clusterService = clusterService;
         this.shardStateAction = shardStateAction;
         this.transportService = transportService;

diff --git a/...ava/org/elasticsearch/action/support/replication/TransportBroadcastReplicationAction.java b/...ava/org/elasticsearch/action/support/replication/TransportBroadcastReplicationAction.java
@@ -66,7 +66,7 @@ public TransportBroadcastReplicationAction(
         ActionType<ShardResponse> replicatedBroadcastShardAction,
         Executor executor
     ) {
-        super(name, true, transportService, actionFilters, requestReader, EsExecutors.DIRECT_EXECUTOR_SERVICE);
+        super(name, transportService, actionFilters, requestReader, EsExecutors.DIRECT_EXECUTOR_SERVICE);
         this.client = client;
         this.replicatedBroadcastShardAction = replicatedBroadcastShardAction;
         this.clusterService = clusterService;

diff --git a/.../elasticsearch/action/support/single/instance/TransportInstanceSingleOperationAction.java b/.../elasticsearch/action/support/single/instance/TransportInstanceSingleOperationAction.java
@@ -66,7 +66,7 @@ protected TransportInstanceSingleOperationAction(
         IndexNameExpressionResolver indexNameExpressionResolver,
         Writeable.Reader<Request> request
     ) {
-        super(actionName, true, transportService, actionFilters, request, EsExecutors.DIRECT_EXECUTOR_SERVICE);
+        super(actionName, transportService, actionFilters, request, EsExecutors.DIRECT_EXECUTOR_SERVICE);
         this.threadPool = threadPool;
         this.clusterService = clusterService;
         this.transportService = transportService;

diff --git a/server/src/main/java/org/elasticsearch/action/synonyms/TransportDeleteSynonymRuleAction.java b/server/src/main/java/org/elasticsearch/action/synonyms/TransportDeleteSynonymRuleAction.java
@@ -26,7 +26,6 @@ public class TransportDeleteSynonymRuleAction extends HandledTransportAction<Del
     public TransportDeleteSynonymRuleAction(TransportService transportService, ActionFilters actionFilters, Client client) {
         super(
             DeleteSynonymRuleAction.NAME,
-            true,
             transportService,
             actionFilters,
             DeleteSynonymRuleAction.Request::new,

diff --git a/server/src/main/java/org/elasticsearch/action/synonyms/TransportDeleteSynonymsAction.java b/server/src/main/java/org/elasticsearch/action/synonyms/TransportDeleteSynonymsAction.java
@@ -27,7 +27,6 @@ public class TransportDeleteSynonymsAction extends HandledTransportAction<Delete
     public TransportDeleteSynonymsAction(TransportService transportService, ActionFilters actionFilters, Client client) {
         super(
             DeleteSynonymsAction.NAME,
-            true,
             transportService,
             actionFilters,
             DeleteSynonymsAction.Request::new,

diff --git a/server/src/main/java/org/elasticsearch/action/synonyms/TransportGetSynonymRuleAction.java b/server/src/main/java/org/elasticsearch/action/synonyms/TransportGetSynonymRuleAction.java
@@ -26,7 +26,6 @@ public class TransportGetSynonymRuleAction extends HandledTransportAction<GetSyn
     public TransportGetSynonymRuleAction(TransportService transportService, ActionFilters actionFilters, Client client) {
         super(
             GetSynonymRuleAction.NAME,
-            true,
             transportService,
             actionFilters,
             GetSynonymRuleAction.Request::new,

diff --git a/server/src/main/java/org/elasticsearch/action/synonyms/TransportGetSynonymsAction.java b/server/src/main/java/org/elasticsearch/action/synonyms/TransportGetSynonymsAction.java
@@ -24,14 +24,7 @@ public class TransportGetSynonymsAction extends HandledTransportAction<GetSynony
 
     @Inject
     public TransportGetSynonymsAction(TransportService transportService, ActionFilters actionFilters, Client client) {
-        super(
-            GetSynonymsAction.NAME,
-            true,
-            transportService,
-            actionFilters,
-            GetSynonymsAction.Request::new,
-            EsExecutors.DIRECT_EXECUTOR_SERVICE
-        );
+        super(GetSynonymsAction.NAME, transportService, actionFilters, GetSynonymsAction.Request::new, EsExecutors.DIRECT_EXECUTOR_SERVICE);
 
         this.synonymsManagementAPIService = new SynonymsManagementAPIService(client);
     }

diff --git a/server/src/main/java/org/elasticsearch/action/synonyms/TransportGetSynonymsSetsAction.java b/server/src/main/java/org/elasticsearch/action/synonyms/TransportGetSynonymsSetsAction.java
@@ -26,7 +26,6 @@ public class TransportGetSynonymsSetsAction extends HandledTransportAction<GetSy
     public TransportGetSynonymsSetsAction(TransportService transportService, ActionFilters actionFilters, Client client) {
         super(
             GetSynonymsSetsAction.NAME,
-            true,
             transportService,
             actionFilters,
             GetSynonymsSetsAction.Request::new,