Skip to content

Commit

Permalink
remove size tests
Browse files Browse the repository at this point in the history
  • Loading branch information
dnhatn committed Dec 3, 2017
1 parent c9a4901 commit 14aca62
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 33 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
package org.elasticsearch.index.translog;

import com.carrotsearch.hppc.LongObjectHashMap;
import com.carrotsearch.hppc.cursors.ObjectCursor;
import org.apache.lucene.util.BitSet;
import org.elasticsearch.common.util.CountedBitSet;
import org.elasticsearch.index.seqno.SequenceNumbers;
Expand Down Expand Up @@ -104,21 +103,5 @@ boolean getAndSet(long value) {
bitset.set(index);
return wasOn;
}

// For testing
long completeSetsSize() {
int completedBitSets = 0;
for (ObjectCursor<BitSet> bitset : bitSets.values()) {
if (bitset.value.cardinality() == bitset.value.length()) {
completedBitSets++;
}
}
return completedBitSets;
}

// For testing
long ongoingSetsSize() {
return bitSets.size() - completeSetsSize();
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
import java.util.stream.LongStream;

import static org.hamcrest.CoreMatchers.equalTo;
import static org.hamcrest.Matchers.lessThanOrEqualTo;

public class MultiSnapshotTests extends ESTestCase {

Expand All @@ -40,14 +39,8 @@ public void testTrackSeqNoSimpleRange() throws Exception {
Randomness.shuffle(values);
for (int i = 0; i < 1023; i++) {
assertThat(bitSet.getAndSet(values.get(i)), equalTo(false));
assertThat(bitSet.ongoingSetsSize(), equalTo(1L));
assertThat(bitSet.completeSetsSize(), equalTo(0L));
}

assertThat(bitSet.getAndSet(values.get(1023)), equalTo(false));
assertThat(bitSet.ongoingSetsSize(), equalTo(0L));
assertThat(bitSet.completeSetsSize(), equalTo(1L));

assertThat(bitSet.getAndSet(between(0, 1023)), equalTo(true));
assertThat(bitSet.getAndSet(between(1024, Integer.MAX_VALUE)), equalTo(false));
}
Expand All @@ -59,7 +52,6 @@ public void testTrackSeqNoDenseRanges() throws Exception {
long seq = between(0, 5000);
boolean existed = normalSet.add(seq) == false;
assertThat("SeqNoSet != Set" + seq, bitSet.getAndSet(seq), equalTo(existed));
assertThat(bitSet.ongoingSetsSize() + bitSet.completeSetsSize(), lessThanOrEqualTo(5L));
});
}

Expand All @@ -78,12 +70,8 @@ public void testTrackSeqNoMimicTranslogRanges() throws Exception {
final LongSet normalSet = new LongHashSet();
long currentSeq = between(10_000_000, 1_000_000_000);
final int iterations = scaledRandomIntBetween(100, 2000);
assertThat(bitSet.completeSetsSize(), equalTo(0L));
assertThat(bitSet.ongoingSetsSize(), equalTo(0L));
long totalDocs = 0;
for (long i = 0; i < iterations; i++) {
int batchSize = between(1, 1500);
totalDocs += batchSize;
currentSeq -= batchSize;
List<Long> batch = LongStream.range(currentSeq, currentSeq + batchSize)
.boxed()
Expand All @@ -92,11 +80,7 @@ public void testTrackSeqNoMimicTranslogRanges() throws Exception {
batch.forEach(seq -> {
boolean existed = normalSet.add(seq) == false;
assertThat("SeqNoSet != Set", bitSet.getAndSet(seq), equalTo(existed));
assertThat(bitSet.ongoingSetsSize(), lessThanOrEqualTo(4L));
});
assertThat(bitSet.ongoingSetsSize(), lessThanOrEqualTo(2L));
}
assertThat(bitSet.completeSetsSize(), lessThanOrEqualTo(totalDocs / 1024));
assertThat(bitSet.ongoingSetsSize(), lessThanOrEqualTo(2L));
}
}

0 comments on commit 14aca62

Please sign in to comment.