Skip to content

Commit

Permalink
TESTS+DISTR.: Fix testIndexCheckOnStartup Flake (#33349)
Browse files Browse the repository at this point in the history
* Ignore all `RuntimeException` since random
file corruption triggers other RTE in addition
to the randomly caught one
* closes #33345
  • Loading branch information
original-brownbear authored Sep 3, 2018
1 parent a9d2b1d commit 42424af
Showing 1 changed file with 1 addition and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2596,7 +2596,6 @@ public void testReadSnapshotConcurrently() throws IOException, InterruptedExcept
closeShards(newShard);
}

@AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/33345")
public void testIndexCheckOnStartup() throws Exception {
final IndexShard indexShard = newStartedShard(true);

Expand Down Expand Up @@ -2650,7 +2649,7 @@ public FileVisitResult visitFile(Path file, BasicFileAttributes attrs) throws IO
try {
closeShards(corruptedShard);
} catch (RuntimeException e) {
assertThat(e.getMessage(), equalTo("CheckIndex failed"));
// Ignored because corrupted shard can throw various exceptions on close
}
}

Expand Down

0 comments on commit 42424af

Please sign in to comment.