MINOR: Remove Deadcode in ExpressionTermSetQuery (#34442)

elastic · Oct 15, 2018 · 5115262 · 5115262
1 parent 55eaf7a
commit 5115262
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/...-expression/src/main/java/org/elasticsearch/script/expression/ExpressionScriptEngine.java b/...-expression/src/main/java/org/elasticsearch/script/expression/ExpressionScriptEngine.java
@@ -221,8 +221,7 @@ private TermsSetQueryScript.LeafFactory newTermsSetQueryScript(Expression expr,
                 throw convertToScriptException("link error", expr.sourceText, variable, e);
             }
         }
-        ReplaceableConstDoubleValueSource specialValue = null;
-        return new ExpressionTermSetQueryScript(expr, bindings, specialValue);
+        return new ExpressionTermSetQueryScript(expr, bindings);
     }
 
     /**

diff --git a/...ssion/src/main/java/org/elasticsearch/script/expression/ExpressionTermSetQueryScript.java b/...ssion/src/main/java/org/elasticsearch/script/expression/ExpressionTermSetQueryScript.java
@@ -38,13 +38,11 @@ class ExpressionTermSetQueryScript implements TermsSetQueryScript.LeafFactory {
     final Expression exprScript;
     final SimpleBindings bindings;
     final DoubleValuesSource source;
-    final ReplaceableConstDoubleValueSource specialValue; // _value
 
-    ExpressionTermSetQueryScript(Expression e, SimpleBindings b, ReplaceableConstDoubleValueSource v) {
+    ExpressionTermSetQueryScript(Expression e, SimpleBindings b) {
         exprScript = e;
         bindings = b;
         source = exprScript.getDoubleValuesSource(bindings);
-        specialValue = v;
     }
 
     @Override