Networking: Fix test leaking buffer (#32296)

* Test `handler` must release buffer the same way the replaced `org.elasticsearch.http.netty4.Netty4HttpRequestHandler#channelRead0` releases it * Closes #32289
elastic · Jul 24, 2018 · 717df26 · 717df26
1 parent 54ba3ea
commit 717df26
Showing 1 changed file with 24 additions and 19 deletions.
diff --git a/...t-netty4/src/test/java/org/elasticsearch/http/netty4/Netty4HttpServerPipeliningTests.java b/...t-netty4/src/test/java/org/elasticsearch/http/netty4/Netty4HttpServerPipeliningTests.java
@@ -181,27 +181,32 @@ class PossiblySlowRunnable implements Runnable {
 
         @Override
         public void run() {
-            final String uri = fullHttpRequest.uri();
-
-            final ByteBuf buffer = Unpooled.copiedBuffer(uri, StandardCharsets.UTF_8);
-
-            Netty4HttpRequest httpRequest = new Netty4HttpRequest(fullHttpRequest, pipelinedRequest.getSequence());
-            Netty4HttpResponse response = httpRequest.createResponse(RestStatus.OK, new BytesArray(uri.getBytes(StandardCharsets.UTF_8)));
-            response.headers().add(HttpHeaderNames.CONTENT_LENGTH, buffer.readableBytes());
-
-            final boolean slow = uri.matches("/slow/\\d+");
-            if (slow) {
-                try {
-                    Thread.sleep(scaledRandomIntBetween(500, 1000));
-                } catch (InterruptedException e) {
-                    throw new RuntimeException(e);
+            try {
+                final String uri = fullHttpRequest.uri();
+
+                final ByteBuf buffer = Unpooled.copiedBuffer(uri, StandardCharsets.UTF_8);
+
+                Netty4HttpRequest httpRequest = new Netty4HttpRequest(fullHttpRequest, pipelinedRequest.getSequence());
+                Netty4HttpResponse response =
+                    httpRequest.createResponse(RestStatus.OK, new BytesArray(uri.getBytes(StandardCharsets.UTF_8)));
+                response.headers().add(HttpHeaderNames.CONTENT_LENGTH, buffer.readableBytes());
+
+                final boolean slow = uri.matches("/slow/\\d+");
+                if (slow) {
+                    try {
+                        Thread.sleep(scaledRandomIntBetween(500, 1000));
+                    } catch (InterruptedException e) {
+                        throw new RuntimeException(e);
+                    }
+                } else {
+                    assert uri.matches("/\\d+");
                 }
-            } else {
-                assert uri.matches("/\\d+");
-            }
 
-            final ChannelPromise promise = ctx.newPromise();
-            ctx.writeAndFlush(response, promise);
+                final ChannelPromise promise = ctx.newPromise();
+                ctx.writeAndFlush(response, promise);
+            } finally {
+                fullHttpRequest.release();
+            }
         }
 
     }