Skip to content

Commit

Permalink
Cleanup outdated comments for fixing up pom dependencies (#24056)
Browse files Browse the repository at this point in the history
  • Loading branch information
rjernst authored Apr 12, 2017
1 parent 1207103 commit 7cebc0f
Showing 1 changed file with 1 addition and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -311,16 +311,9 @@ class BuildPlugin implements Plugin<Project> {
/**
* Returns a closure which can be used with a MavenPom for fixing problems with gradle generated poms.
*
* <ul>
* <li>Remove transitive dependencies. We currently exclude all artifacts explicitly instead of using wildcards
* as Ivy incorrectly translates POMs with * excludes to Ivy XML with * excludes which results in the main artifact
* being excluded as well (see https://issues.apache.org/jira/browse/IVY-1531). Note that Gradle 2.14+ automatically
* translates non-transitive dependencies to * excludes. We should revisit this when upgrading Gradle.</li>
* <li>Set compile time deps back to compile from runtime (known issue with maven-publish plugin)</li>
* </ul>
* The current fixup is to set compile time deps back to compile from runtime (known issue with maven-publish plugin).
*/
private static Closure fixupDependencies(Project project) {
// TODO: revisit this when upgrading to Gradle 2.14+, see Javadoc comment above
return { XmlProvider xml ->
// first find if we have dependencies at all, and grab the node
NodeList depsNodes = xml.asNode().get('dependencies')
Expand Down

0 comments on commit 7cebc0f

Please sign in to comment.