NETWORKING:Def CName in Http Publish Addr to True (#33631)

* Follow up to #32806 setting the setting to true for 7.x
elastic · Sep 18, 2018 · 87cedef · 87cedef
1 parent 1391288
commit 87cedef
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 7 deletions.
diff --git a/buildSrc/src/main/groovy/org/elasticsearch/gradle/BuildPlugin.groovy b/buildSrc/src/main/groovy/org/elasticsearch/gradle/BuildPlugin.groovy
@@ -828,9 +828,6 @@ class BuildPlugin implements Plugin<Project> {
             // TODO: remove this once ctx isn't added to update script params in 7.0
             systemProperty 'es.scripting.update.ctx_in_params', 'false'
 
-            //TODO: remove this once the cname is prepended to the address by default in 7.0
-            systemProperty 'es.http.cname_in_publish_address', 'true'
-
             // Set the system keystore/truststore password if we're running tests in a FIPS-140 JVM
             if (project.inFipsJvm) {
                 systemProperty 'javax.net.ssl.trustStorePassword', 'password'

diff --git a/docs/build.gradle b/docs/build.gradle
@@ -56,8 +56,6 @@ integTestCluster {
 
   // TODO: remove this for 7.0, this exists to allow the doc examples in 6.x to continue using the defaults
   systemProperty 'es.scripting.update.ctx_in_params', 'false'
-  //TODO: remove this once the cname is prepended to the address by default in 7.0
-  systemProperty 'es.http.cname_in_publish_address', 'true'
 }
 
 // remove when https://github.com/elastic/elasticsearch/issues/31305 is fixed

diff --git a/modules/lang-painless/build.gradle b/modules/lang-painless/build.gradle
@@ -25,7 +25,6 @@ esplugin {
 integTestCluster {
   module project.project(':modules:mapper-extras')
   systemProperty 'es.scripting.update.ctx_in_params', 'false'
-  systemProperty 'es.http.cname_in_publish_address', 'true'
 }
 
 dependencies {

diff --git a/server/src/main/java/org/elasticsearch/http/HttpInfo.java b/server/src/main/java/org/elasticsearch/http/HttpInfo.java
@@ -41,7 +41,7 @@ public class HttpInfo implements Writeable, ToXContentFragment {
 
     /** Whether to add hostname to publish host field when serializing. */
     private static final boolean CNAME_IN_PUBLISH_HOST =
-        parseBoolean(System.getProperty("es.http.cname_in_publish_address"), false);
+        parseBoolean(System.getProperty("es.http.cname_in_publish_address"), true);
 
     private final BoundTransportAddress address;
     private final long maxContentLength;