Fix place-holder in allocation decider messages (#27436)

Allocation decider messages were using the wrong place-holder, which resulted in output of the form "no allocations are allowed due to {}" when showing diagnostics information in the explain API.
elastic · Nov 17, 2017 · 8ed0120 · 8ed0120
1 parent d9959d0
commit 8ed0120
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/...src/main/java/org/elasticsearch/cluster/routing/allocation/decider/AllocationDecider.java b/...src/main/java/org/elasticsearch/cluster/routing/allocation/decider/AllocationDecider.java
@@ -118,7 +118,7 @@ public Decision canForceAllocatePrimary(ShardRouting shardRouting, RoutingNode n
             // On a NO decision, by default, we allow force allocating the primary.
             return allocation.decision(Decision.YES,
                                        decision.label(),
-                                       "primary shard [{}] allowed to force allocate on node [{}]",
+                                       "primary shard [%s] allowed to force allocate on node [%s]",
                                        shardRouting.shardId(), node.nodeId());
         } else {
             // On a THROTTLE/YES decision, we use the same decision instead of forcing allocation

diff --git a/...in/java/org/elasticsearch/cluster/routing/allocation/decider/EnableAllocationDecider.java b/...in/java/org/elasticsearch/cluster/routing/allocation/decider/EnableAllocationDecider.java
@@ -116,20 +116,20 @@ public Decision canAllocate(ShardRouting shardRouting, RoutingNode node, Routing
             case ALL:
                 return allocation.decision(Decision.YES, NAME, "all allocations are allowed");
             case NONE:
-                return allocation.decision(Decision.NO, NAME, "no allocations are allowed due to {}", setting(enable, usedIndexSetting));
+                return allocation.decision(Decision.NO, NAME, "no allocations are allowed due to %s", setting(enable, usedIndexSetting));
             case NEW_PRIMARIES:
                 if (shardRouting.primary() && shardRouting.active() == false &&
                     shardRouting.recoverySource().getType() != RecoverySource.Type.EXISTING_STORE) {
                     return allocation.decision(Decision.YES, NAME, "new primary allocations are allowed");
                 } else {
-                    return allocation.decision(Decision.NO, NAME, "non-new primary allocations are forbidden due to {}",
+                    return allocation.decision(Decision.NO, NAME, "non-new primary allocations are forbidden due to %s",
                                                 setting(enable, usedIndexSetting));
                 }
             case PRIMARIES:
                 if (shardRouting.primary()) {
                     return allocation.decision(Decision.YES, NAME, "primary allocations are allowed");
                 } else {
-                    return allocation.decision(Decision.NO, NAME, "replica allocations are forbidden due to {}",
+                    return allocation.decision(Decision.NO, NAME, "replica allocations are forbidden due to %s",
                                                 setting(enable, usedIndexSetting));
                 }
             default: